edit paragraph #28
edit paragraph #28
Conversation
video/scribblings/intro.scrbl
Outdated
| All VidLang programs begin with @code{#lang video}, the | ||
| remaining program is a description of the resulting video. | ||
| All VidLang programs begin with the language declaration @code{#lang video}; and the | ||
| remaining program below is a description of the resulting video, written in expressions. |
There was a problem hiding this comment.
I would change this to be:
remaining program is a description of the resulting video.
Because:
- What does 'above' have to do with anything?
- A Video program is more than just expressions.
There was a problem hiding this comment.
It was an attempt to introduce "expressions" in the paragraph below. I wasn't sure if the program only contained expressions or not.
There was a problem hiding this comment.
I see. Honestly, I think that expressions should evaluate to producers deserves its own sentence.
|
Thanks for the PR. I added comments in the code. |
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 87.13% 87.01% -0.13%
==========================================
Files 41 41
Lines 6251 6345 +94
==========================================
+ Hits 5447 5521 +74
- Misses 804 824 +20
Continue to review full report at Codecov.
|
1 similar comment
…acks section goes next
|
What is your reasoning for moving the Multitracks and merges section to before transitions? Given that transitions only apply to playlists it seems silly to start with playlists, jump to multitracks, and then cover transitions. |
1 similar comment
|
Looking at your commit message, it looks like you answered my previous message:
Anyway, this seems odd to me, since transitions are more closely bound (logically) to playlists. Thus, it seems very odd to me to have:
The order:
Makes more more sense to me. If you want, you could merge them so that the structure is more like:
|
|
Has there been any more progress on this? |
|
Just another quick ping to here about the status of this PR. |
"language declaration" may need to be called something else, but I'd like some similar description of what it is.