APP-7497: Add Switch client, server, and fake models #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanlookpotts
commented
Jan 24, 2025
components/switch/client.go
Outdated
| @@ -0,0 +1,88 @@ | |||
| // Package switch_component contains a gRPC based switch client. | |||
| package switch_component | |||
There was a problem hiding this comment.
Note: switch is a keyword, so the package is called switch_component
There was a problem hiding this comment.
Doesn't matter to me, happy to update to toggleswitch
ethanlookpotts
changed the title
ethanlookpotts
force-pushed
the
APP-7497/ethanlookpotts/switch
branch
from
904d410 to
9038c5c
Compare
ethanlookpotts
force-pushed
the
APP-7497/ethanlookpotts/button
branch
from
d1ec868 to
d62aae2
Compare
ethanlookpotts
force-pushed
the
APP-7497/ethanlookpotts/switch
branch
from
9038c5c to
fc28a0f
Compare
randhid
requested changes
Jan 27, 2025
components/switch/client.go
Outdated
| @@ -0,0 +1,88 @@ | |||
| // Package switch_component contains a gRPC based switch client. | |||
| package switch_component | |||
|
Done with first pass - will look at tests in the second. |
ethanlookpotts
force-pushed
the
APP-7497/ethanlookpotts/switch
branch
5 times, most recently
from
4996b8f to
f31815d
Compare
ethanlookpotts
commented
Jan 28, 2025
Comment on lines
+94
to
+103
| resp, err := client1.DoCommand(context.Background(), testutils.TestCommand) | ||
| test.That(t, err, test.ShouldBeNil) | ||
| test.That(t, resp["command"], test.ShouldEqual, testutils.TestCommand["command"]) | ||
| test.That(t, resp["data"], test.ShouldEqual, testutils.TestCommand["data"]) |
There was a problem hiding this comment.
@randhid any thoughts on why this DoCommand client test would be failing? I've spent a good amount of time debugging and I can't figure it out. For whatever reason, the inject button implementation of DoCommand is not being called.
There was a problem hiding this comment.
There is no server DoCommand implemented for switch https://github.com/viamrobotics/rdk/pull/4741/files#r1933063119
There was a problem hiding this comment.
Ah, thank you for catching this!!
randhid
reviewed
Jan 29, 2025
randhid
reviewed
Jan 29, 2025
components/switch/switch_test.go
Outdated
| @@ -0,0 +1,37 @@ | |||
| package toggleswitch_test | |||
There was a problem hiding this comment.
move this to fake switch's folder.
stevebriskin
approved these changes
Jan 29, 2025
ethanlookpotts
force-pushed
the
APP-7497/ethanlookpotts/button
branch
from
d52ab1b to
1ff98bc
Compare
ethanlookpotts
force-pushed
the
APP-7497/ethanlookpotts/switch
branch
from
f31815d to
5e27be1
Compare
randhid
approved these changes
Jan 29, 2025
ethanlookpotts
force-pushed
the
APP-7497/ethanlookpotts/switch
branch
from
5e27be1 to
60f8380
Compare
viambot
added
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the switch client and server, and registers switch 2-way, 3-way, and 10-way fake models.
Here are switch components properly configured in app:
Change log
I used Cursor quite a bit here:
SwitchSDK helpersReview requests