rand feedback

components/button/client_test.go

@@ -16,6 +16,13 @@ import (
 	"go.viam.com/rdk/testutils/inject"
 )
 
+const (
+	testButtonName    = "button1"
+	testButtonName2   = "button2"
+	failButtonName    = "button3"
+	missingButtonName = "button4"
+)
+
 func TestClient(t *testing.T) {
 	logger := logging.NewTestLogger(t)
 	listener1, err := net.Listen("tcp", "localhost:0")

components/button/button_test.go → components/button/fake/button_test.go

@@ -1,4 +1,4 @@
-package button_test
+package fake_test
 
 import (
 	"context"
@@ -12,13 +12,6 @@ import (
 	"go.viam.com/rdk/resource"
 )
 
-const (
-	testButtonName    = "button1"
-	testButtonName2   = "button2"
-	failButtonName    = "button3"
-	missingButtonName = "button4"
-)
-
 func TestPush(t *testing.T) {
 	logger := logging.NewTestLogger(t)
 	cfg := resource.Config{

components/button/server.go

@@ -36,9 +36,9 @@ func (s *serviceServer) Push(ctx context.Context, req *pb.PushRequest) (*pb.Push
 func (s *serviceServer) DoCommand(ctx context.Context,
 	req *commonpb.DoCommandRequest,
 ) (*commonpb.DoCommandResponse, error) {
-	gripper, err := s.coll.Resource(req.GetName())
+	button, err := s.coll.Resource(req.GetName())
 	if err != nil {
 		return nil, err
 	}
-	return protoutils.DoFromResourceServer(ctx, gripper, req)
+	return protoutils.DoFromResourceServer(ctx, button, req)
 }

components/button/server_test.go

@@ -67,7 +67,7 @@ func TestServer(t *testing.T) {
 
 		_, err = buttonServer.Push(context.Background(), &pb.PushRequest{Name: testButtonName2})
 		test.That(t, err, test.ShouldNotBeNil)
-		test.That(t, err.Error(), test.ShouldContainSubstring, errCantPush.Error())
+		test.That(t, err, test.ShouldBeError, errCantPush)
 		test.That(t, buttonPushed, test.ShouldEqual, testButtonName2)
 	})