RSDK-4334 add option to disable server discovery via mdns #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
maximpertsov
commented
Aug 23, 2023
| @@ -40,6 +40,7 @@ type Arguments struct { | |||
| RevealSensitiveConfigDiffs bool `flag:"reveal-sensitive-config-diffs,usage=show config diffs"` | |||
| UntrustedEnv bool `flag:"untrusted-env,usage=disable processes and shell from running in a untrusted environment"` | |||
| OutputTelemetry bool `flag:"output-telemetry,usage=print out telemetry data (metrics and spans)"` | |||
| DisableMulticastDNS bool `flag:"disable-mdns,usage=disable server discovery through multicast DNS"` | |||
There was a problem hiding this comment.
should this be a "positive" option with a default of true like the corresponding -webrtc flag? personally, I would prefer to change the webrtc flag to be negative (e.g. -disable-webrtc) so the default would be false, but am hesitant to change the existing interface.
thoughts?
There was a problem hiding this comment.
I think the two should be consistent, and I don't think we should change the existing interface, so I prefer the positive option with a default of true
There was a problem hiding this comment.
I left the option on the underlying struct negative since we can't change the default value on that - we get test failures otherwise: 6b7c51f
There was a problem hiding this comment.
anyway to fix the tests? I don't think the two should be different
There was a problem hiding this comment.
discussed IRL, we're gonna make the new option negative
viambot
added
safe to test
maximpertsov
force-pushed
the
add-disable-mdns-opt
branch
from
b1e7808 to
6b7c51f
Compare
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
This reverts commit 6b7c51f.
cheukt
approved these changes
Aug 24, 2023
Code Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to support a more rigorous dial scenario testing, but probably a useful configuration to expose in general.