RSDK-4334 add option to disable server discovery via mdns (viamrobotics#2826)

Author: maximpertsov

robot/web/options/options.go

@@ -67,6 +67,8 @@ type Options struct {
 
 	WebRTCOnPeerAdded   func(pc *webrtc.PeerConnection)
 	WebRTCOnPeerRemoved func(pc *webrtc.PeerConnection)
+
+	DisableMulticastDNS bool
 }
 
 // New returns a default set of options which will have the

robot/web/web.go

@@ -927,6 +927,10 @@ func (svc *webService) initRPCOptions(listenerTCPAddr *net.TCPAddr, options webo
 			OnPeerRemoved:             options.WebRTCOnPeerRemoved,
 		}),
 	}
+	if options.DisableMulticastDNS {
+		rpcOpts = append(rpcOpts, rpc.WithDisableMulticastDNS())
+	}
+
 	var unaryInterceptors []googlegrpc.UnaryServerInterceptor
 
 	unaryInterceptors = append(unaryInterceptors, ensureTimeoutUnaryInterceptor)

web/server/entrypoint.go

@@ -54,6 +54,7 @@ type Arguments struct {
 	RevealSensitiveConfigDiffs bool   `flag:"reveal-sensitive-config-diffs,usage=show config diffs"`
 	UntrustedEnv               bool   `flag:"untrusted-env,usage=disable processes and shell from running in a untrusted environment"`
 	OutputTelemetry            bool   `flag:"output-telemetry,usage=print out telemetry data (metrics and spans)"`
+	DisableMulticastDNS        bool   `flag:"disable-mdns,usage=disable server discovery through multicast DNS"`
 }
 
 type robotServer struct {
@@ -198,6 +199,7 @@ func (s *robotServer) createWebOptions(cfg *config.Config) (weboptions.Options,
 	options.SharedDir = s.args.SharedDir
 	options.Debug = s.args.Debug || cfg.Debug
 	options.WebRTC = s.args.WebRTC
+	options.DisableMulticastDNS = s.args.DisableMulticastDNS
 	if cfg.Cloud != nil && s.args.AllowInsecureCreds {
 		options.SignalingDialOpts = append(options.SignalingDialOpts, rpc.WithAllowInsecureWithCredentialsDowngrade())
 	}