maxim pr

viamrobotics · Sep 18, 2024 · 3f34f81 · 3f34f81
1 parent 36fd416
commit 3f34f81
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/rpc/js/src/BaseStream.ts b/rpc/js/src/BaseStream.ts
@@ -5,12 +5,12 @@ let MaxMessageSize = 1 << 25;
 
 export class BaseStream {
   protected readonly grpcStream: Stream;
-  private readonly onDone: (id: number) => void;
+  private readonly onDone: (id: bigint) => void;
   protected closed: boolean = false;
   private readonly packetBuf: Array<Uint8Array> = [];
   private packetBufSize = 0;
 
-  constructor(grpcStream: Stream, onDone: (id: number) => void) {
+  constructor(grpcStream: Stream, onDone: (id: bigint) => void) {
     this.grpcStream = grpcStream;
     this.onDone = onDone;
   }
@@ -20,7 +20,7 @@ export class BaseStream {
       return;
     }
     this.closed = true;
-    this.onDone(Number(this.grpcStream.id));
+    this.onDone(this.grpcStream.id);
   }
 
   protected processPacketMessage(msg: PacketMessage): Uint8Array | undefined {

diff --git a/rpc/js/src/ClientChannel.ts b/rpc/js/src/ClientChannel.ts
@@ -31,7 +31,7 @@ interface activeClienStream {
 
 export class ClientChannel extends BaseChannel implements Transport {
   private streamIDCounter = 0;
-  private readonly streams: Record<number, activeClienStream> = {};
+  private readonly streams: Record<string, activeClienStream> = {};
 
   constructor(pc: RTCPeerConnection, dc: RTCDataChannel) {
     super(pc, dc);
@@ -75,7 +75,7 @@ export class ClientChannel extends BaseChannel implements Transport {
     }
 
     const { id } = stream;
-    const activeStream = this.streams[Number(id)];
+    const activeStream = this.streams[id.toString()];
     if (activeStream === undefined) {
       console.error('no stream for id; discarding', 'id', id);
       return;
@@ -95,22 +95,22 @@ export class ClientChannel extends BaseChannel implements Transport {
         new ConnectionClosedError('connection closed')
       );
     }
-    let activeStream = this.streams[Number(stream.id)];
+    let activeStream = this.streams[stream.id.toString()];
     if (activeStream === undefined) {
       if (Object.keys(this.streams).length > MaxStreamCount) {
         return new FailingClientStream(new Error('stream limit hit'));
       }
-      const clientStream = new ClientStream(this, stream, (id: number) =>
+      const clientStream = new ClientStream(this, stream, (id: bigint) =>
         this.removeStreamByID(id)
       );
       activeStream = { cs: clientStream };
-      this.streams[Number(stream.id)] = activeStream;
+      this.streams[stream.id.toString()] = activeStream;
     }
     return activeStream.cs;
   }
 
-  private removeStreamByID(id: number) {
-    delete this.streams[id];
+  private removeStreamByID(id: bigint) {
+    delete this.streams[id.toString()];
   }
 
   public writeHeaders(stream: Stream, headers: RequestHeaders) {

diff --git a/rpc/js/src/ClientStream.ts b/rpc/js/src/ClientStream.ts
@@ -49,7 +49,7 @@ export class ClientStream extends BaseStream implements Transport {
   constructor(
     channel: ClientChannel,
     stream: Stream,
-    onDone: (id: number) => void
+    onDone: (id: bigint) => void
   ) {
     super(stream, onDone);
     this.channel = channel;