Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-2436: Change inclusion table header #3028

Merged
merged 21 commits into from
Jun 17, 2024
Merged

DOCS-2436: Change inclusion table header #3028

merged 21 commits into from
Jun 17, 2024

Conversation

npentrel
Copy link
Collaborator

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jun 17, 2024
@viambot
Copy link
Member

viambot commented Jun 17, 2024 •
edited
Loading

Overall readability score: 53 (🟢 +0)

File Readability
processes.md 68.57 (🟢 +0)
two_wheeled_base.md 34.81 (🟢 +0)
esp32.md 71.62 (🟢 +0)
incremental.md 52.75 (🟢 +0)
single.md 35.93 (🟢 +0)
gpio.md 73.36 (🟢 +0)
accel-adxl345.md 51.47 (🟢 +0)
gyro-mpu6050.md 46.71 (🟢 +0)
ultrasonic.md 39.31 (🟢 +0)
gpio.md 48.43 (🟢 +0)
cli.md 71.68 (🟢 +1.11)
fake.md 57.13 (🟢 +0)
lite6.md 49.89 (🟢 +0)
ur5e.md 58.48 (🟢 +0)
xarm6.md 49.25 (🟢 +0)
xarm7.md 49.25 (🟢 +0)
boat.md 68.47 (🟢 +0)
sensor-controlled.md 40.86 (🟢 +0)
wheeled.md 55.92 (🟢 +0)
beaglebone.md 26.87 (🟢 +0)
customlinux.md 75.03 (🟢 +0)
fake.md 39.9 (🟢 +0)
jetson.md 37.36 (🟢 +0)
numato.md 36.29 (🟢 +0)
odroid.md 32.7 (🟢 +0)
orangepi.md 40.77 (🟢 +0)
pca9685.md 52.99 (🟢 +0)
pi.md 38.25 (🟢 +0)
pi5.md 37.01 (🟢 +0)
ti.md 29.4 (🟢 +0)
upboard.md 43.99 (🟢 +0)
fake.md 57.28 (🟢 +0)
ffmpeg.md 65.74 (🟢 +0)
image-file.md 69.04 (🟢 +0)
join-color-depth.md 64.02 (🟢 +0)
join-pointclouds.md 54.42 (🟢 +0)
transform.md 65.59 (🟢 +0)
velodyne.md 24.92 (🟢 +0)
webcam.md 60.03 (🟢 +0)
board1.md 36.38 (🟢 +0)
model1.md 45.55 (🟢 +0)
ams-as5048.md 42.59 (🟢 +0)
arduino.md 66.19 (🟢 +0)
incremental.md 42.54 (🟢 +0)
single.md 49.19 (🟢 +0)
multi-axis.md 50.95 (🟢 +0)
single-axis.md 54.77 (🟢 +0)
softrobotics.md 49.57 (🟢 +0)
fake.md 48.93 (🟢 +0)
gamepad.md 50.17 (🟢 +0)
gpio.md 52.63 (🟢 +0)
mux.md 35.85 (🟢 +0)
28byj48.md 44.81 (🟢 +0)
dmc4000.md 64.03 (🟢 +0)
encoded-motor.md 43.07 (🟢 +0)
fake.md 65.24 (🟢 +0)
gpio.md 70.76 (🟢 +0)
gpiostepper.md 55.98 (🟢 +0)
roboclaw.md 52.86 (🟢 +0)
tmc5072.md 65.97 (🟢 +0)
adxl345.md 58.02 (🟢 +0)
cameramono.md 54.1 (🟢 +0)
dual-gps-rtk.md 52.91 (🟢 +0)
gps-nmea-rtk-pmtk.md 49.89 (🟢 +0)
gps-nmea-rtk-serial.md 45.4 (🟢 +0)
gps-nmea.md 52.3 (🟢 +0)
imu-vectornav.md 40.98 (🟢 +0)
imu-wit-hwt905.md 36.22 (🟢 +0)
imu-wit.md 45.66 (🟢 +0)
merged.md 48.49 (🟢 +0)
mpu6050.md 41.07 (🟢 +0)
wheeled-odometry.md 45.43 (🟢 +0)
ina219.md 47.52 (🟢 +0)
ina226.md 45.33 (🟢 +0)
renogy.md 32.62 (🟢 +0)
bme280.md 43.04 (🟢 +0)
ds18b20.md 38.52 (🟢 +0)
sensirion-sht3xd.md 42.2 (🟢 +0)
gpio.md 39.73 (🟢 +0)
pi.md 34.55 (🟢 +0)
configure.md 66.19 (🟢 +0)
_index.md 51.42 (🟢 +0)
_index.md 55.97 (🟢 +0)
trigger-sync.md 66.29 (🟢 +0)
_index.md 51.5 (🟢 +0)
frame-config.md 61.94 (🟢 +0)
nested-frame-config.md 63.34 (🟢 +0)
tflite_cpu.md 59.57 (🟢 +0)
_index.md 63.95 (🟢 +0)
_index.md 64.88 (🟢 +0)
_index.md 66.95 (🟢 +0)
color_detector.md 58.47 (🟢 +0)
detector_3d_segmenter.md 68.92 (🟢 +0)
mlmodel.md 55.13 (🟢 +0)
obstacles_depth.md 54.48 (🟢 +0)
obstacles_distance.md 46.05 (🟢 +0)
obstacles_pointcloud.md 54.48 (🟢 +0)
board-analogs.md 55.69 (🟢 +0)
board-digital-interrupts.md 48.75 (🟢 +0)
ultrasonic-attributes.md 52.63 (🟢 +0)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
processes.md 68.57 56.35 8.86 10.5 10.66 6.83
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
two_wheeled_base.md 34.81 37.84 13.56 19 13.35 8.85
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
esp32.md 71.62 57.16 8.69 9.7 10.08 6.63
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
incremental.md 52.75 46.47 11.43 13.3 12.41 7.84
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
single.md 35.93 32.73 14.65 17.1 13.69 8.37
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gpio.md 73.36 57.98 8.02 10.3 9.96 6.27
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
accel-adxl345.md 51.47 44.64 10.93 14.2 12.35 8.03
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gyro-mpu6050.md 46.71 44.24 11.93 15 13.23 8.21
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
ultrasonic.md 39.31 40.99 13.29 17.4 13.81 8.28
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gpio.md 48.43 41.9 12.16 15.4 11.95 7.81
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
cli.md 71.68 46.67 7.9 10.8 10.84 5.66
  🟢 +1.11 🟢 +0.5 🟢 +0.22 🟢 +0.4 🟢 +0 🟢 +0.02
fake.md 57.13 53.92 11.54 12.8 11.42 7.46
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
lite6.md 49.89 47.18 11.11 14.3 13.63 7.95
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
ur5e.md 58.48 51.24 9.12 12.1 12.22 8.16
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
xarm6.md 49.25 47.79 11.07 14.4 13.85 8.06
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
xarm7.md 49.25 47.79 11.07 14.4 13.85 8.06
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
boat.md 68.47 59.4 8.95 9.9 11.12 7.04
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
sensor-controlled.md 40.86 29.38 13.02 17.5 13.99 7.22
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
wheeled.md 55.92 47.59 9.91 13.6 13.04 7.31
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
beaglebone.md 26.87 28.94 13.57 19.2 18.09 8.69
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
customlinux.md 75.03 65.22 8.61 9.2 9.33 6.58
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
fake.md 39.9 32.6 11.86 15.9 16.17 8.07
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
jetson.md 37.36 34.66 13.29 16.5 14.56 8.64
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
numato.md 36.29 32.09 13.35 15.1 15.54 9.01
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
odroid.md 32.7 29.45 12.41 17.9 16.99 8.59
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
orangepi.md 40.77 28.94 11.48 17.2 15.66 7.45
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
pca9685.md 52.99 55.64 12 13.1 12.58 7.95
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
pi.md 38.25 28.64 12.38 16.9 15.37 8
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
pi5.md 37.01 35.07 12.82 17.9 15.26 8.08
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
ti.md 29.4 28.43 12.86 19.2 17.51 8.51
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
upboard.md 43.99 33.71 10.65 14.6 15.41 8.42
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
fake.md 57.28 48.09 10.24 12.7 12 7.6
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
ffmpeg.md 65.74 50.84 8.63 10.8 11.24 7.16
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
image-file.md 69.04 58.28 8.93 10.4 10.48 6.87
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
join-color-depth.md 64.02 48.3 9.16 11.7 11.48 6.77
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
join-pointclouds.md 54.42 47.38 9.62 13.9 13.28 7.68
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
transform.md 65.59 49.92 8.09 12.1 12.4 6.35
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
velodyne.md 24.92 14.15 12.24 19.4 18.44 9
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
webcam.md 60.03 46.17 10.16 12.2 11.37 7.19
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
board1.md 36.38 29.86 12.15 17.3 16.3 8.18
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
model1.md 45.55 44.24 12.52 15.1 13.05 8.29
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
ams-as5048.md 42.59 38.42 12.4 15.3 14.61 8.2
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
arduino.md 66.19 56.35 9.84 11.5 10.08 6.85
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
incremental.md 42.54 32.94 12.76 16.9 13.69 7.42
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
single.md 49.19 43.43 12.09 15 12.59 7.59
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
multi-axis.md 50.95 47.69 10.45 14.1 13.33 8.22
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
single-axis.md 54.77 47.89 10.8 12.6 12.29 7.99
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
softrobotics.md 49.57 47.28 10.29 15.6 14.44 7.55
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
fake.md 48.93 39.63 10.07 14.1 14.03 8.33
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gamepad.md 50.17 43.93 11.88 13.9 12.59 7.92
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gpio.md 52.63 35.78 10.43 14.5 13.52 6.83
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
mux.md 35.85 27.52 12.59 17 16.13 8.2
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
28byj48.md 44.81 43.12 11.6 16.7 14.39 7.64
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
dmc4000.md 64.03 47.69 8.68 12.3 11.48 6.72
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
encoded-motor.md 43.07 31.41 12.91 16 13.29 7.68
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
fake.md 65.24 52.29 10.3 12 9.98 6.51
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gpio.md 70.76 62.58 9.36 11.1 9.68 6.36
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gpiostepper.md 55.98 50.06 11.34 14.2 11.43 7.09
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
roboclaw.md 52.86 45.46 10.74 14.2 12.58 7.64
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
tmc5072.md 65.97 56.45 9.14 11.2 10.72 7.15
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
adxl345.md 58.02 45.66 10.14 13.1 12.29 6.99
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
cameramono.md 54.1 39.43 11.57 11.5 11.65 8.13
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
dual-gps-rtk.md 52.91 53.21 11.49 13.7 12.58 7.85
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gps-nmea-rtk-pmtk.md 49.89 44.85 10.86 14.8 13.51 7.79
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gps-nmea-rtk-serial.md 45.4 41.6 11.84 16.5 13.69 7.65
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gps-nmea.md 52.3 45.46 10.62 14.6 13.05 7.49
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
imu-vectornav.md 40.98 42.11 12.12 16.9 13.87 8.64
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
imu-wit-hwt905.md 36.22 30.7 12.97 18.4 13.99 8.35
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
imu-wit.md 45.66 36.89 10.79 15.9 14.21 7.93
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
merged.md 48.49 33.75 11.81 15 13.34 7.13
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
mpu6050.md 41.07 44.24 12.37 16.3 14.74 8.48
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
wheeled-odometry.md 45.43 35.17 11.92 15.4 14.68 7.33
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
ina219.md 47.52 41.16 10.25 14.7 14.14 8.43
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
ina226.md 45.33 39.84 10.77 15.2 14.26 8.49
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
renogy.md 32.62 24.07 13.47 18.7 14.85 8.35
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
bme280.md 43.04 39.23 11.66 15.1 14.67 8.56
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
ds18b20.md 38.52 30.67 12.21 15.4 15.42 8.77
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
sensirion-sht3xd.md 42.2 39.43 11.67 15.4 15.13 8.49
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
gpio.md 39.73 33.54 12.59 17.4 13.69 8.19
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
pi.md 34.55 36.63 14.32 19.2 13.29 8.4
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
configure.md 66.19 45.56 8.36 12.7 11.95 5.72
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
_index.md 51.42 37.34 11.7 16.4 12.54 6.18
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
_index.md 55.97 44.95 9.99 14.1 12.58 7.09
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
trigger-sync.md 66.29 60.75 10.46 11.6 10.1 6.66
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
_index.md 51.5 41.4 11.39 15.4 13 6.78
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
frame-config.md 61.94 56.35 10.89 11.2 10.78 7.44
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
nested-frame-config.md 63.34 54.22 10.65 11.6 10.67 6.89
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
tflite_cpu.md 59.57 57.2 11.78 13.4 10.33 6.95
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
_index.md 63.95 46.67 8.14 13.5 13.16 5.7
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
_index.md 64.88 51.89 9.73 12.5 11.14 6.17
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
_index.md 66.95 53.92 9.59 11.3 10.15 6.68
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
color_detector.md 58.47 49.75 11.36 13.5 10.44 7.04
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
detector_3d_segmenter.md 68.92 60.35 10.48 10.5 8.59 6.97
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
mlmodel.md 55.13 46.2 11.9 15.5 10.86 6.52
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
obstacles_depth.md 54.48 55.07 12.61 14.9 11.09 6.97
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
obstacles_distance.md 46.05 43.36 13.97 16.7 10.86 7.55
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
obstacles_pointcloud.md 54.48 53.34 12.84 15.2 10.39 6.93
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
board-analogs.md 55.69 45.05 11.04 12.9 11.66 7.57
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
board-digital-interrupts.md 48.75 44.24 11.9 14.7 13.4 7.65
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
ultrasonic-attributes.md 52.63 37.91 10.46 14.4 13.11 7.15
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0

Averages:

  Readability FRE GF ARI CLI DCRS
Average 53 45.62 11.12 12.66 12.14 8.29
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

npentrel
npentrel commented Jun 17, 2024
View reviewed changes
docs/components/arm/ur5e.md Outdated Show resolved Hide resolved
JessamyT
JessamyT approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@JessamyT JessamyT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple opt questions. Also realizing maybe we should make name be attribute for all component attributes.

docs/services/slam/orbslamv3/_index.md Outdated Show resolved Hide resolved
static/include/services/cartographer/configparams.md Show resolved Hide resolved
@viambot
Copy link
Member

viambot commented Jun 17, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3028

@npentrel npentrel merged commit a2f6d63 into viamrobotics:main Jun 17, 2024
9 of 10 checks passed
@npentrel npentrel deleted the DOCS-2436 branch June 17, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessamyT JessamyT JessamyT approved these changes

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npentrel @viambot @JessamyT