Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Java UDx #248
Add support for Java UDx #248
Changes from 33 commits
ff9e1bb
e92a246
fef8181
67a7227
972523d
ac580d5
6036bb0
431e3e5
551a0b2
9062007
ec3b0a0
a757f36
2566d88
e7f47d2
716c2c3
fc84201
75b3391
859fae1
6c1db22
e860bb1
677941c
652b677
336af93
2c3559c
2d6125a
b833edf
314c782
9afba3d
5703d45
af62c3c
2ddcc91
8761e44
e6a073d
d7cc2b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we need to do this? I removed this and was still able to run the python udx from /opt/vertica/sdk/examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to do this. Zhuoyu thought it would be a convenience if our python3 was in a normal path instead of needing to add /opt/vertica/oss/python3/bin/ to one's path.
(I don't know if he has scripts that expect python3 to be ours without changing the path.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zhuoyu reminded me that we needed this to run one of the sample C++ udx. There is some code that invokes python to generate a bunch of numbers for the test. We want to build a CI that runs the udx tests, so adding this to the container made sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does
bin/udx-libs/build
get built? There isn't any change to the Makefile, so I assume there is a manual step somewhere. Did we look at building these in a container?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still in the process of testing building those UDx libs locally. If I can build them locally in my WSL2 Ubuntu then I guess I could also build it in a Ubuntu container in GitHub action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I guess this will be considered a follow-on item.