-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Java UDx #248
Conversation
Modify one command line option supplied to command cut in order to retrieve all fields after and including the second field (with - set as the field separator)
Change KUBEVER to 1.23.0 to ensure kind create cluster could succeed
Adding a new vertica image with jre pre-installed through apt; adding new make targets as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm done my first pass of the changes.
Co-authored-by: spilchen <[email protected]>
Co-authored-by: spilchen <[email protected]>
Co-authored-by: spilchen <[email protected]>
Co-authored-by: spilchen <[email protected]>
Co-authored-by: spilchen <[email protected]>
Co-authored-by: spilchen <[email protected]>
Co-authored-by: spilchen <[email protected]>
Co-authored-by: spilchen <[email protected]>
Co-authored-by: spilchen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for applying the code review comments.
echo "JAVA_HOME=/usr" >> /etc/environment; \ | ||
fi \ | ||
# Create a symlink to python3 interpreter in vertica | ||
&& update-alternatives --install /usr/bin/python python /opt/vertica/oss/python3/bin/python3 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we need to do this? I removed this and was still able to run the python udx from /opt/vertica/sdk/examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to do this. Zhuoyu thought it would be a convenience if our python3 was in a normal path instead of needing to add /opt/vertica/oss/python3/bin/ to one's path.
(I don't know if he has scripts that expect python3 to be ours without changing the path.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zhuoyu reminded me that we needed this to run one of the sample C++ udx. There is some code that invokes python to generate a bunch of numbers for the test. We want to build a CI that runs the udx tests, so adding this to the container made sense.
The main vertica image is modified to use package manager to install jre-headless, depending on whether the image should be minimal or not. The /opt/vertica/sdk folder is preserved if image is not minimal. A symlink to python3 interpreter in vertica is installed in /usr/bin. The java udx tests are added. The sample manifests are added.
This also changes the Kubernetes version used in the CI to 1.23.0. This change was done locally so that tests could be run in a WSL2 environment.