Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Java UDx #248

Merged
merged 34 commits into from
Aug 19, 2022
Merged

Add support for Java UDx #248

merged 34 commits into from
Aug 19, 2022

Conversation

jizhuoyu
Copy link
Collaborator

@jizhuoyu jizhuoyu commented Aug 17, 2022

The main vertica image is modified to use package manager to install jre-headless, depending on whether the image should be minimal or not. The /opt/vertica/sdk folder is preserved if image is not minimal. A symlink to python3 interpreter in vertica is installed in /usr/bin. The java udx tests are added. The sample manifests are added.

This also changes the Kubernetes version used in the CI to 1.23.0. This change was done locally so that tests could be run in a WSL2 environment.

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2022

CLA assistant check
All committers have signed the CLA.

@spilchen spilchen self-requested a review August 17, 2022 18:47
Copy link
Collaborator

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm done my first pass of the changes.

scripts/setup-kustomize.sh Outdated Show resolved Hide resolved
config/samples/v1beta1_verticadb_new_design.yaml Outdated Show resolved Hide resolved
config/samples/v1beta1_verticadb_host_mount_java.yaml Outdated Show resolved Hide resolved
config/samples/v1beta1_verticadb_host_mount.yaml Outdated Show resolved Hide resolved
docker-vertica/docker-entrypoint.sh Outdated Show resolved Hide resolved
tests/e2e-udx/udx-java/51-verify-java-uda.yaml Outdated Show resolved Hide resolved
tests/e2e-udx/udx-java/52-verify-java-udl.yaml Outdated Show resolved Hide resolved
tests/e2e-udx/udx-java/setup-vdb/base/setup-vdb.yaml Outdated Show resolved Hide resolved
@spilchen spilchen changed the title Local e2e test Add support for Java, C++ and Python UDx Aug 18, 2022
Copy link
Collaborator

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for applying the code review comments.

echo "JAVA_HOME=/usr" >> /etc/environment; \
fi \
# Create a symlink to python3 interpreter in vertica
&& update-alternatives --install /usr/bin/python python /opt/vertica/oss/python3/bin/python3 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we need to do this? I removed this and was still able to run the python udx from /opt/vertica/sdk/examples.

Copy link
Collaborator

@dmankins dmankins Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to do this. Zhuoyu thought it would be a convenience if our python3 was in a normal path instead of needing to add /opt/vertica/oss/python3/bin/ to one's path.

(I don't know if he has scripts that expect python3 to be ours without changing the path.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zhuoyu reminded me that we needed this to run one of the sample C++ udx. There is some code that invokes python to generate a bunch of numbers for the test. We want to build a CI that runs the udx tests, so adding this to the container made sense.

@spilchen spilchen changed the title Add support for Java, C++ and Python UDx Add support for Java UDx Aug 19, 2022
@spilchen spilchen merged commit d0ce5e6 into vertica:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants