Change some internal packer APIs to not use C-style arrays #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
github-actions
bot
added
the
libarchfpga
AmirhosseinPoolad
force-pushed
the
pack_remove_c_arr
branch
2 times, most recently
from
a4772a1 to
3129316
Compare
AmirhosseinPoolad
force-pushed
the
pack_remove_c_arr
branch
from
3129316 to
69f1528
Compare
This commit changes some functions that used C-style arrays to use std::vector instead. Previously we used the .data() method of std::vectors to pass a pointer to these functions.
This commit changes two functions in the prepacker to get the specific element of the array they work with and not the entire array.
AmirhosseinPoolad
force-pushed
the
pack_remove_c_arr
branch
from
69f1528 to
313a984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes some functions in the packer and prepacker that used C-style arrays to use std::vector instead. Previously we used the .data() method of std::vector to pass a pointer to these functions.