Add ability to generate DID from seed. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSAssassin
force-pushed
the
generate-did-from-seed
branch
from
531d9aa
to
9b6edc8
Compare
JSAssassin
force-pushed
the
generate-did-from-seed
branch
from
9b6edc8
to
f4aed86
Compare
dlongley
approved these changes
Dec 14, 2021
Co-authored-by: Dave Longley <[email protected]>
aljones15
approved these changes
Jan 3, 2022
| @@ -173,6 +176,23 @@ describe('methods/veres-one', () => { | |||
| expect(didDocument.id).to.match(/^did:v1:nym:z.*/); | |||
| }); | |||
|
|
|||
| it('should generate a DID document from seed', async () => { | |||
| const seedBytes = (new TextEncoder()).encode(TEST_SEED).slice(0, 32); | |||
There was a problem hiding this comment.
This is a really interesting way of generating a 32-byte seed. @davidlehn Do we have a recommended way of generating a 32-byte seed from a string? @JSAssassin I don't think this is wrong, but it just got me wondering how we should be turning strings into 32-byte seeds. Also of note: this code comes from the did-method-key-js test suite here: https://github.com/digitalbazaar/did-method-key/blob/602b82f8f3c71d687035e5642f3e32fa2651e2d0/test/driver.spec.js#L201-L213
@dmitrizagidulin uses this method to generate test data so I think it's ok. I would like consensus on how we want to turn strings into 32-byte unit8 arrays, but for a test this is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #74