Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1.generate({seed}) feature, to match did:key driver #74

Closed
dmitrizagidulin opened this issue Oct 29, 2021 · 6 comments
Closed

Add v1.generate({seed}) feature, to match did:key driver #74

dmitrizagidulin opened this issue Oct 29, 2021 · 6 comments
Assignees

Comments

@dmitrizagidulin
Copy link
Contributor

Add the ability to generate a new Veres One DID from a seed, to match did:key driver.
(Just like with did:key, if a seed param is present, use it to generate a capabilityInvocation key.)

Note: Make the PR off of #60 / v14.x branch.

@msporny
Copy link
Contributor

msporny commented Nov 16, 2021

Where do we use this feature? Why do we need it?

@dmitrizagidulin
Copy link
Contributor Author

@msporny - we use this in did-io, and were using it in our admin CLI tool.

@msporny
Copy link
Contributor

msporny commented Nov 16, 2021

@msporny - we use this in did-io, and were using it in our admin CLI tool.

Yes, but why? What's the use case? Someone wants to use an external random number generator for a seed? Someone wants to physically imprint the seed on titanium plates?

@aljones15
Copy link
Contributor

just a small note, this makes did-veres-one have the same generate interface as did-method-key. This helps as right now if you want your app to be cross-compatible with did-method-key and did-veres-one you have to generate did-method-key from a 32-byte Uint8Array and then did-veres-one from an Ed25519Key. Basically, did-veres-one requires an extra step.

@aljones15
Copy link
Contributor

I believe this can be closed as this was is now a feature in v14.x #75

@JSAssassin
Copy link
Contributor

Closing, implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants