Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #9203

Merged
merged 2 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"typescript.referencesCodeLens.enabled": true,
"eslint.validate": ["javascript", "javascriptreact", "typescript", "typescriptreact"],
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happened because of a VSCode change shift from 1.84 to 1.85, when boolean values for properties was deprecated. This change just shipped this month ( https://stackoverflow.com/a/77637765 ).

},
"[markdown]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
Expand Down
3 changes: 1 addition & 2 deletions babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ module.exports = {
}
],
'@babel/preset-typescript'
],
plugins: ['@babel/proposal-class-properties']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the NPM page: https://www.npmjs.com/package/@babel/plugin-proposal-class-properties

This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.

Upon inspection of the new site ( https://babeljs.io/docs/babel-plugin-transform-class-properties ). It appears this plugin is safe to drop because it's been moved to @babel/preset-en as long as you support ES2022 .

]
};
31 changes: 15 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,51 +79,50 @@
"url": "https://github.com/vega/vega-lite/issues"
},
"devDependencies": {
"@babel/core": "^7.23.3",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/preset-env": "^7.23.3",
"@babel/core": "^7.23.6",
"@babel/preset-env": "^7.23.6",
"@babel/preset-typescript": "^7.23.3",
"@release-it/conventional-changelog": "^8.0.1",
"@rollup/plugin-alias": "^5.1.0",
"@rollup/plugin-babel": "^6.0.4",
"@rollup/plugin-commonjs": "^25.0.7",
"@rollup/plugin-json": "^6.0.1",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-terser": "^0.4.4",
"@types/chai": "^4.3.11",
"@types/d3": "^7.4.3",
"@types/jest": "^29.5.10",
"@types/jest": "^29.5.11",
"@types/pako": "^2.0.3",
"@typescript-eslint/eslint-plugin": "^6.12.0",
"@typescript-eslint/parser": "^6.12.0",
"@typescript-eslint/eslint-plugin": "^6.14.0",
"@typescript-eslint/parser": "^6.14.0",
"ajv": "^8.12.0",
"ajv-formats": "^2.1.1",
"chai": "^4.3.10",
"cheerio": "^1.0.0-rc.12",
"conventional-changelog-cli": "^4.1.0",
"d3": "^7.8.5",
"del-cli": "^5.1.0",
"eslint": "^8.54.0",
"eslint-config-prettier": "^9.0.0",
"eslint": "^8.55.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-jest": "^27.6.0",
"eslint-plugin-prettier": "^5.0.1",
"fast-json-stable-stringify": "~2.1.0",
"highlight.js": "^11.9.0",
"jest": "^29.7.0",
"jest-dev-server": "^9.0.1",
"jest-dev-server": "^9.0.2",
"mkdirp": "^3.0.1",
"pako": "^2.1.0",
"prettier": "^3.1.0",
"prettier": "^3.1.1",
"puppeteer": "^15.0.0",
"release-it": "^17.0.0",
"rollup": "^4.6.0",
"release-it": "^17.0.1",
"rollup": "^4.8.0",
"rollup-plugin-bundle-size": "^1.0.3",
"rollup-plugin-sourcemaps": "^0.6.3",
"serve": "^14.2.1",
"terser": "^5.24.0",
"terser": "^5.26.0",
"ts-jest": "^29.1.1",
"ts-json-schema-generator": "^1.4.1",
"typescript": "~5.3.2",
"ts-json-schema-generator": "^1.5.0",
"typescript": "~5.3.3",
"vega-cli": "^5.26.1",
"vega-datasets": "^2.7.0",
"vega-embed": "^6.23.0",
Expand Down
3 changes: 1 addition & 2 deletions test-runtime/babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ module.exports = {
}
],
'@babel/preset-typescript'
],
plugins: ['@babel/proposal-class-properties']
]
};
Loading