Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #9203

Merged
merged 2 commits into from
Dec 20, 2023
Merged

chore: update deps #9203

merged 2 commits into from
Dec 20, 2023

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Dec 13, 2023

Remove @babel/plugin-proposal-class-properties since it's not a proposal anymore. Also update a vscode setting.

@domoritz domoritz requested a review from a team as a code owner December 13, 2023 00:08
@domoritz domoritz enabled auto-merge (squash) December 13, 2023 00:08
Copy link
Member

@hydrosquall hydrosquall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change contains 3 distinct adjustments

  1. Updates VSCode settings to match the defaults of the latest version of VSCode
  2. Removes the @babel/proposal-class-properties plugin
  3. Updates a battery of devDependencies

I'm usually used to updating 1 of these things at a time in other projects, but these changes seem reasonable to me both individually and in aggregate . Leaning on CI to catch any surprise consequences of the package upgrades ✅

@@ -10,6 +10,5 @@ module.exports = {
}
],
'@babel/preset-typescript'
],
plugins: ['@babel/proposal-class-properties']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the NPM page: https://www.npmjs.com/package/@babel/plugin-proposal-class-properties

This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.

Upon inspection of the new site ( https://babeljs.io/docs/babel-plugin-transform-class-properties ). It appears this plugin is safe to drop because it's been moved to @babel/preset-en as long as you support ES2022 .

@@ -19,7 +19,7 @@
"typescript.referencesCodeLens.enabled": true,
"eslint.validate": ["javascript", "javascriptreact", "typescript", "typescriptreact"],
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happened because of a VSCode change shift from 1.84 to 1.85, when boolean values for properties was deprecated. This change just shipped this month ( https://stackoverflow.com/a/77637765 ).

@domoritz domoritz merged commit fa225a9 into main Dec 20, 2023
@domoritz domoritz deleted the dom/updates-823496 branch December 20, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants