enhancement(cli): Adds optional file output to generate subcommand #4819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeyun
changed the title
eeyun
force-pushed
the
eeyun/gen_output_file
branch
from
2f2f567 to
35d7bf2
Compare
eeyun
changed the title
eeyun
changed the title
bruceg
reviewed
Oct 30, 2020
eeyun
force-pushed
the
eeyun/gen_output_file
branch
2 times, most recently
from
f65d3e0 to
da01010
Compare
Hoverbear
approved these changes
Nov 2, 2020
Hoverbear
suggested changes
Nov 2, 2020
Signed-off-by: Ian Henry <[email protected]>
eeyun
force-pushed
the
eeyun/gen_output_file
branch
2 times, most recently
from
c6ce0d8 to
07be056
Compare
Hoverbear
approved these changes
Nov 3, 2020
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
…v#4819) Signed-off-by: Ian Henry <[email protected]> Signed-off-by: Brian Menges <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3013
This PR should be straightforward. Not entirely confident on team patterns just yet but we effectively now take an extra argument for the
generatesubcommand of a filepath and we write the config to that location. It's a pretty dumb implementation. We check if the file already exists and pass an error if so. If its a directory path we create the directories assuming the user has the permissions to do so.Signed-off-by: Ian Henry [email protected]