Skip to content

fix(tests): require features for generate_configfile test #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2020
Merged

fix(tests): require features for generate_configfile test #5427

merged 3 commits into from
Dec 8, 2020

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Dec 7, 2020

Added in #4819

Test should not be compiled without required features.

@fanatid fanatid added the domain: tests Anything related to Vector's internal tests label Dec 7, 2020
@fanatid fanatid requested a review from eeyun December 7, 2020 10:43
@fanatid fanatid self-assigned this Dec 7, 2020
jszwedko
jszwedko reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you might want to move use tempfile::tempdir; into generate_configfile to avoid the unused import for other component features..

@fanatid
clippy fix
6e3ada3 
Signed-off-by: Kirill Fomichev <[email protected]>
@fanatid
Copy link
Contributor Author

fanatid commented Dec 8, 2020

Thanks @jszwedko! Stupid CI fail from me 🤦

jszwedko
jszwedko reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like cleanup_configfile might need a cfg block too 😄

@fanatid
fix clippy #2
6af6587 
Signed-off-by: Kirill Fomichev <[email protected]>
@fanatid
Copy link
Contributor Author

fanatid commented Dec 8, 2020

Now should be okay. Tested locally with a different set of features.

jszwedko
jszwedko approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fanatid fanatid merged commit 8b3d595 into master Dec 8, 2020
@fanatid fanatid deleted the cfg-for-test branch December 8, 2020 17:45
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
@fanatid
fix(tests): require features for generate_configfile test (vectordotd…
dd931ab 
…ev#5427)

Signed-off-by: Kirill Fomichev <[email protected]>
Signed-off-by: Brian Menges <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

@eeyun eeyun Awaiting requested review from eeyun

Assignees

@fanatid fanatid

Labels
domain: tests Anything related to Vector's internal tests
Projects
None yet
Milestone
2020-12-07: Nanite Repair System
Development

Successfully merging this pull request may close these issues.
2 participants
@fanatid @jszwedko