-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add write perms to the default data_dir #19659
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 2093 Passed, 0 Skipped, 1m 25.46s Wall Time |
Regression Detector ResultsRun ID: 01556dc1-2715-4850-a21d-ae16ac661ce9 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +1.47 | [+1.35, +1.58] |
➖ | fluent_elasticsearch | ingress throughput | +1.08 | [+0.61, +1.55] |
➖ | syslog_humio_logs | ingress throughput | +0.39 | [+0.27, +0.50] |
➖ | syslog_loki | ingress throughput | +0.37 | [+0.32, +0.42] |
➖ | http_text_to_http_json | ingress throughput | +0.30 | [+0.17, +0.42] |
➖ | http_elasticsearch | ingress throughput | +0.16 | [+0.08, +0.23] |
➖ | http_to_http_noack | ingress throughput | +0.13 | [+0.04, +0.23] |
➖ | socket_to_socket_blackhole | ingress throughput | +0.13 | [+0.08, +0.18] |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | +0.06 | [-0.03, +0.14] |
➖ | http_to_http_json | ingress throughput | +0.05 | [-0.03, +0.13] |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.15, +0.16] |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.00 | [-0.14, +0.14] |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -0.00 | [-0.13, +0.13] |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.05 | [-0.17, +0.06] |
➖ | enterprise_http_to_http | ingress throughput | -0.06 | [-0.14, +0.03] |
➖ | syslog_splunk_hec_logs | ingress throughput | -0.17 | [-0.23, -0.11] |
➖ | http_to_s3 | ingress throughput | -0.19 | [-0.47, +0.10] |
➖ | otlp_grpc_to_blackhole | ingress throughput | -0.45 | [-0.53, -0.37] |
➖ | syslog_log2metric_humio_metrics | ingress throughput | -0.51 | [-0.60, -0.41] |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -0.92 | [-1.00, -0.84] |
➖ | datadog_agent_remap_blackhole | ingress throughput | -1.13 | [-1.22, -1.03] |
➖ | otlp_http_to_blackhole | ingress throughput | -1.44 | [-1.58, -1.29] |
➖ | splunk_hec_route_s3 | ingress throughput | -1.66 | [-2.15, -1.17] |
➖ | http_to_http_acks | ingress throughput | -1.77 | [-3.07, -0.47] |
➖ | file_to_blackhole | egress throughput | -1.98 | [-4.41, +0.45] |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -2.12 | [-2.26, -1.98] |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -3.15 | [-3.27, -3.03] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Regression Detector ResultsRun ID: 3db7cc5a-4880-4327-9e1d-dd5bcbe9bef0 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | splunk_hec_route_s3 | ingress throughput | +1.17 | [+0.67, +1.67] |
➖ | datadog_agent_remap_blackhole | ingress throughput | +0.91 | [+0.81, +1.01] |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | +0.61 | [+0.53, +0.69] |
➖ | otlp_http_to_blackhole | ingress throughput | +0.51 | [+0.38, +0.64] |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +0.51 | [+0.42, +0.60] |
➖ | http_to_http_acks | ingress throughput | +0.41 | [-0.89, +1.72] |
➖ | http_to_s3 | ingress throughput | +0.15 | [-0.13, +0.44] |
➖ | http_to_http_noack | ingress throughput | +0.11 | [+0.01, +0.21] |
➖ | http_to_http_json | ingress throughput | +0.06 | [-0.02, +0.14] |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.00 | [-0.14, +0.15] |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.15, +0.16] |
➖ | enterprise_http_to_http | ingress throughput | -0.02 | [-0.10, +0.07] |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.04 | [-0.15, +0.08] |
➖ | socket_to_socket_blackhole | ingress throughput | -0.15 | [-0.22, -0.09] |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -0.22 | [-0.30, -0.14] |
➖ | syslog_splunk_hec_logs | ingress throughput | -0.42 | [-0.48, -0.36] |
➖ | otlp_grpc_to_blackhole | ingress throughput | -0.42 | [-0.51, -0.34] |
➖ | syslog_humio_logs | ingress throughput | -0.44 | [-0.57, -0.32] |
➖ | syslog_log2metric_humio_metrics | ingress throughput | -0.53 | [-0.65, -0.42] |
➖ | http_elasticsearch | ingress throughput | -0.64 | [-0.72, -0.56] |
➖ | http_text_to_http_json | ingress throughput | -0.76 | [-0.88, -0.63] |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -1.15 | [-1.30, -1.01] |
➖ | syslog_loki | ingress throughput | -1.21 | [-1.27, -1.15] |
➖ | fluent_elasticsearch | ingress throughput | -1.22 | [-1.69, -0.75] |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -1.39 | [-1.49, -1.28] |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -1.57 | [-1.70, -1.44] |
➖ | file_to_blackhole | egress throughput | -2.00 | [-4.43, +0.44] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/ci-run-misc |
/ci-run-cli |
Regression Detector ResultsRun ID: c53ef226-c623-430b-b558-4a387aacc7e5 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | syslog_log2metric_humio_metrics | ingress throughput | +2.78 | [+2.65, +2.90] |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | +1.40 | [+1.26, +1.54] |
➖ | http_elasticsearch | ingress throughput | +0.77 | [+0.69, +0.85] |
➖ | splunk_hec_route_s3 | ingress throughput | +0.73 | [+0.23, +1.23] |
➖ | datadog_agent_remap_blackhole | ingress throughput | +0.46 | [+0.38, +0.55] |
➖ | syslog_humio_logs | ingress throughput | +0.41 | [+0.33, +0.49] |
➖ | syslog_splunk_hec_logs | ingress throughput | +0.30 | [+0.23, +0.38] |
➖ | file_to_blackhole | egress throughput | +0.27 | [-2.31, +2.84] |
➖ | http_to_s3 | ingress throughput | +0.23 | [-0.05, +0.52] |
➖ | http_to_http_noack | ingress throughput | +0.12 | [+0.02, +0.23] |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | +0.09 | [-0.00, +0.19] |
➖ | http_to_http_json | ingress throughput | +0.02 | [-0.05, +0.10] |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.00 | [-0.14, +0.14] |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.15, +0.15] |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.05 | [-0.16, +0.07] |
➖ | enterprise_http_to_http | ingress throughput | -0.07 | [-0.14, +0.01] |
➖ | fluent_elasticsearch | ingress throughput | -0.08 | [-0.54, +0.39] |
➖ | otlp_http_to_blackhole | ingress throughput | -0.11 | [-0.26, +0.03] |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -0.34 | [-0.42, -0.25] |
➖ | syslog_loki | ingress throughput | -0.63 | [-0.70, -0.57] |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -0.69 | [-0.81, -0.58] |
➖ | http_text_to_http_json | ingress throughput | -0.78 | [-0.90, -0.67] |
➖ | http_to_http_acks | ingress throughput | -1.03 | [-2.33, +0.26] |
➖ | otlp_grpc_to_blackhole | ingress throughput | -1.17 | [-1.26, -1.08] |
➖ | socket_to_socket_blackhole | ingress throughput | -1.19 | [-1.29, -1.10] |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -1.25 | [-1.38, -1.11] |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -1.40 | [-1.49, -1.31] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
* fix: add write perms to the default data_dir * move chmod to bootstrap script * create /var/lib/vector if it doesn't exist * fix validate_cleanup test * compare sets so that ordering doesn't matter * give more perms to the data_dir * use std HashSet (IDE auto-imported the wrong thing)
No description provided.