fix(config): revert acquire exclusive lock to global data dir

[jszwedko]

Reverts #19595

Causing test failures on master.

[github-actions]

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

[github-actions]

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

[github-actions]

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

[datadog-vectordotdev]

Datadog Report

Branch report: revert-19595-OPW-281/lock-global-data-dir
Commit report: 90e0b71
Test service: vector

✅ 0 Failed, 2093 Passed, 0 Skipped, 1m 23.75s Wall Time

[jszwedko]

We might be able to just roll forward too if it is easy, but staging this in case we want to roll back.

cc/ @pront you can see the failures here: https://github.com/vectordotdev/vector/actions/runs/7563041449

[pront]

We might be able to just roll forward too if it is easy, but staging this in case we want to roll back.

cc/ @pront you can see the failures here: https://github.com/vectordotdev/vector/actions/runs/7563041449

I will take a look tomorrow. We can wait before we merge this one but up to you.

[jszwedko]

Thanks for the approval. I'll merge now just to keep CI green, but we can re-merge the change tomorrow.

[github-actions]

Regression Detector Results

Run ID: 7736cee7-e1f1-4d6f-91e8-00bb32e00589
Baseline: 58a37b2
Comparison: 87d9c4b
Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI
✅	http_elasticsearch	ingress throughput	+8.50	[+8.42, +8.58]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
✅	http_elasticsearch	ingress throughput	+8.50	[+8.42, +8.58]
➖	fluent_elasticsearch	ingress throughput	+3.40	[+2.92, +3.87]
➖	datadog_agent_remap_blackhole	ingress throughput	+1.97	[+1.87, +2.08]
➖	http_to_s3	ingress throughput	+1.89	[+1.61, +2.18]
➖	splunk_hec_route_s3	ingress throughput	+1.43	[+0.92, +1.93]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	+1.36	[+1.27, +1.46]
➖	syslog_humio_logs	ingress throughput	+1.02	[+0.94, +1.11]
➖	file_to_blackhole	egress throughput	+0.97	[-1.45, +3.38]
➖	datadog_agent_remap_datadog_logs	ingress throughput	+0.50	[+0.41, +0.59]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.33	[+0.23, +0.42]
➖	otlp_grpc_to_blackhole	ingress throughput	+0.25	[+0.16, +0.34]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+0.17	[+0.05, +0.28]
➖	http_to_http_noack	ingress throughput	+0.11	[+0.04, +0.18]
➖	syslog_loki	ingress throughput	+0.07	[+0.00, +0.15]
➖	http_to_http_json	ingress throughput	+0.04	[-0.04, +0.12]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.15, +0.15]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	-0.01	[-0.15, +0.14]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.02	[-0.14, +0.09]
➖	syslog_splunk_hec_logs	ingress throughput	-0.09	[-0.16, -0.03]
➖	enterprise_http_to_http	ingress throughput	-0.13	[-0.22, -0.05]
➖	syslog_log2metric_humio_metrics	ingress throughput	-0.37	[-0.46, -0.27]
➖	http_text_to_http_json	ingress throughput	-0.66	[-0.78, -0.54]
➖	socket_to_socket_blackhole	ingress throughput	-1.02	[-1.10, -0.95]
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	-1.33	[-1.44, -1.23]
➖	otlp_http_to_blackhole	ingress throughput	-1.35	[-1.49, -1.20]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	-1.40	[-1.55, -1.26]
➖	http_to_http_acks	ingress throughput	-1.74	[-3.04, -0.44]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pront]

This should fix the failures: #19659

[github-actions]

Regression Detector Results

Run ID: d1b8d81a-fdd5-490c-afa2-7cc6e1dbbd58
Baseline: 58a37b2
Comparison: 71e45c9
Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI
✅	http_elasticsearch	ingress throughput	+8.02	[+7.95, +8.09]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
✅	http_elasticsearch	ingress throughput	+8.02	[+7.95, +8.09]
➖	fluent_elasticsearch	ingress throughput	+2.41	[+1.94, +2.88]
➖	http_to_s3	ingress throughput	+1.72	[+1.44, +2.00]
➖	http_to_http_acks	ingress throughput	+1.32	[+0.00, +2.65]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+1.31	[+1.18, +1.44]
➖	syslog_splunk_hec_logs	ingress throughput	+1.19	[+1.12, +1.27]
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	+1.14	[+1.05, +1.23]
➖	datadog_agent_remap_blackhole	ingress throughput	+0.92	[+0.83, +1.00]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	+0.79	[+0.65, +0.93]
➖	syslog_loki	ingress throughput	+0.78	[+0.71, +0.85]
➖	syslog_humio_logs	ingress throughput	+0.57	[+0.48, +0.66]
➖	http_to_http_noack	ingress throughput	+0.15	[+0.06, +0.24]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	+0.13	[+0.03, +0.22]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.08	[+0.00, +0.16]
➖	http_to_http_json	ingress throughput	+0.03	[-0.05, +0.10]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.16, +0.15]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	-0.00	[-0.15, +0.14]
➖	enterprise_http_to_http	ingress throughput	-0.02	[-0.09, +0.05]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.04	[-0.15, +0.08]
➖	splunk_hec_route_s3	ingress throughput	-0.10	[-0.59, +0.40]
➖	otlp_grpc_to_blackhole	ingress throughput	-0.13	[-0.22, -0.04]
➖	socket_to_socket_blackhole	ingress throughput	-0.16	[-0.23, -0.09]
➖	http_text_to_http_json	ingress throughput	-0.25	[-0.39, -0.11]
➖	datadog_agent_remap_datadog_logs	ingress throughput	-0.52	[-0.61, -0.44]
➖	file_to_blackhole	egress throughput	-1.80	[-4.20, +0.61]
➖	otlp_http_to_blackhole	ingress throughput	-1.94	[-2.08, -1.81]
➖	syslog_log2metric_humio_metrics	ingress throughput	-3.73	[-3.85, -3.60]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pront]

Closing in favor of #19659