Skip to content

Set Rust flag codegen-units to 1 for release Vector builds #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Feb 15, 2020 · 1 comment
Closed

Set Rust flag codegen-units to 1 for release Vector builds #1798

ghost opened this issue Feb 15, 2020 · 1 comment
Labels
domain: ci Anything related to Vector's CI environment domain: releasing Anything related to releasing Vector needs: approval Needs review & approval before work can begin. type: task Generic non-code related tasks

Comments

@ghost
Copy link

ghost commented Feb 15, 2020

The results of tests performed by @bruceg in #309 (comment) show that codegen-units=1 Rust flag can reduce Vector binary size by 13%.

I think it is worth to add support for setting it to scripts/build-archive.sh script and enable it by default for release archives.

@ghost ghost added domain: operations type: task Generic non-code related tasks labels Feb 15, 2020
@ghost ghost mentioned this issue Feb 15, 2020
4 tasks
@binarylogic binarylogic assigned ghost Apr 13, 2020
@Hoverbear Hoverbear assigned Hoverbear and unassigned ghost Jun 15, 2020
@binarylogic binarylogic added domain: ci Anything related to Vector's CI environment and removed domain: operations labels Jul 29, 2020
@binarylogic binarylogic added the domain: releasing Anything related to releasing Vector label Aug 7, 2020
@binarylogic binarylogic added the needs: approval Needs review & approval before work can begin. label Aug 17, 2020
@tobz
Copy link
Contributor

tobz commented Aug 9, 2022

This is already happening, both for CI runs (defined here, called here) and published artifacts (configured here).

@tobz tobz closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment domain: releasing Anything related to releasing Vector needs: approval Needs review & approval before work can begin. type: task Generic non-code related tasks
Projects
None yet
3 participants