-
Notifications
You must be signed in to change notification settings - Fork 1.7k
perf(tests): Enable optimizations for benchmarks #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
do you have any bench numbers for this? |
I've updated the issue to close #1798 as well. |
Luke noted in #2326 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The defaults are here:
[profile.bench]
opt-level = 3
debug = false
debug-assertions = false
overflow-checks = false
lto = false
panic = 'unwind' # This setting is always ignored.
incremental = false
codegen-units = 16
rpath = false
So the diff here is really lto
and codegen-units
(I'd like to keep debug = true
so we can still profile benchmarks by default). I imagine the biggest difference here is in build times. I worry that significantly increasing those will slow down our iteration time on benches, but it would be nice to have those numbers be better representative of production builds.
Do you have any numbers on the difference in build time for benchmarks with the above changes?
@a-rodin is this still relevant given the comments? |
@a-rodin mind chiming in here? |
@Hoverbear should we close this? If so, can we address the linked issues as well? |
CLosing... |
Closes #2326.
Closes #1798.