Skip to content

perf(operations): Set -C codegen-units=1 for release builds #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

perf(operations): Set -C codegen-units=1 for release builds #2311

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2020

Closes #1798.

@binarylogic binarylogic requested a review from bruceg April 13, 2020 12:25
bruceg
bruceg reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into Cargo.toml so that make build also gets this set?

@bruceg bruceg assigned ghost and unassigned bruceg Apr 13, 2020
@ghost ghost mentioned this pull request Apr 13, 2020
Closed
@ghost
Copy link
Author

ghost commented Apr 13, 2020 •
edited by ghost
Loading

@bruceg

Should this go into Cargo.toml so that make build also gets this set?

This is something worth to consider, as it makes sense to ensure that the same level of optimizations is enabled for all builds, not only those produced using make build-{archive,deb,rpm}. But then it should also be applicable to Rust codegen LTO, as it is another "slow" optimization which improves performance and is enabled only in build-archive.sh script. Because of that I've opened a separate issue #2315.

@ghost
Copy link
Author

ghost commented Apr 14, 2020

Superseded by #2321.

@ghost ghost closed this Apr 14, 2020
@binarylogic binarylogic deleted the rustc-codegen-units-1 branch April 24, 2020 20:40
@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. domain: performance Anything related to Vector's performance and removed type: performance labels Aug 6, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain: performance Anything related to Vector's performance type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set Rust flag codegen-units to 1 for release Vector builds
4 participants
@Hoverbear @bruceg @binarylogic @a-rodin