Bms relay fsm (4/4 fault checks done) #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 4, 2024 19:56
Akashem06
changed the title
Akashem06
changed the title
Bafran
reviewed
Feb 8, 2024
| @@ -251,6 +258,10 @@ StatusCode ltc_afe_impl_init(LtcAfeStorage *afe, const LtcAfeSettings *settings) | |||
| return prv_write_config(afe, gpio_bits); | |||
| } | |||
|
|
|||
| StatusCode ltc_afe_impl_fault_check() { | |||
| return STATUS_CODE_OK | fault_bitset; | |||
| void close_relays(); | ||
| void open_relays(); | ||
|
|
||
| DECLARE_FSM(relays); |
| StatusCode fault_bitset = STATUS_CODE_OK; | ||
|
|
||
| StatusCode current_sense_fault_check() { | ||
| return STATUS_CODE_OK | fault_bitset; |
There was a problem hiding this comment.
Maybe use the global variable or juts return the variable
| .scl = BMS_PERIPH_I2C_SCL_PIN, | ||
| }; | ||
|
|
||
| GpioAddress const POS_RELAY_EN = { .port = GPIO_PORT_B, .pin = 8 }; |
There was a problem hiding this comment.
nit: I think we usually have const first before the type, and usually use all caps for macros or definitions
| status |= current_sense_fault_check(); | ||
|
|
||
| status |= ltc_afe_impl_trigger_cell_conv(&s_ltc_store); | ||
| // delay_ms(10); |
| LOG_DEBUG("Bms fault check \n"); | ||
| StatusCode status = STATUS_CODE_OK; | ||
|
|
||
| status |= current_sense_fault_check(); |
|
|
||
| status |= ltc_afe_impl_read_cells(&s_ltc_store); | ||
| for (int cell = 0; cell < 12; cell++) { | ||
| LOG_DEBUG("CELL %d: %d\n\r", cell, |
There was a problem hiding this comment.
Add a todo because this only logs we dont do anything with the readings here
…use master task to fall out of sync + return spi status timeout
…dd in fault handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done Needs testing