Added simulation project #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarvisWeng
reviewed
Feb 5, 2024
| #include <arpa/inet.h> | ||
| #include <errno.h> | ||
| #include <fcntl.h> | ||
| #include <linux/can.h> |
| I2C_SET_READING, | ||
| SPI_SET_RX, | ||
| UART | ||
| } Operations; |
There was a problem hiding this comment.
Maybe just add a NUM_OF_OPERATIONS at the end
projects/simulation/src/main.c
Outdated
| input = operation; | ||
| switch (input) { | ||
| case GPIO_SET: | ||
| LOG_DEBUG("GPIO_SET\n"); |
There was a problem hiding this comment.
Hm could you just put each operation in a function? It just makes it easier to read
projects/simulation/src/main.c
Outdated
| close(newsockfd); | ||
| close(socketfd); | ||
| } | ||
| #else |
There was a problem hiding this comment.
There is no if. This should only ever run on x86
| } | ||
|
|
||
| #ifdef x86 | ||
| int main(int argc, char *argv[]) { |
There was a problem hiding this comment.
You should be getting the port from the args, but this is fine for now
| #define PORT 2520 | ||
|
|
||
| int main() { | ||
| int socketfd; |
There was a problem hiding this comment.
Also consider putting this socket logic into a function so other users don't need to copy this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.