[VEL-3593] Explicitely import Tether via ESM import instead of relying on global definition #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phndiaye
requested review from
Xegushu,
JulienVannier66 and
nathalieArnoux
and removed request for
a team
8 tasks
phndiaye
changed the title
JulienVannier66
approved these changes
Jul 24, 2024
Xegushu
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Hypertable v1] Instead of relying on the presence of Tether in the global scope, import it explicitely from the packages. This was actually only working because the final apps had Tether in the global scope via ember-tether (which is removed in upfluence/ember-upf-utils#397 and https://github.com/upfluence/facade-web/pull/597).
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes