[VEL-3593/VEL-3588] Remove unused ember-tether #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phndiaye
requested review from
Xegushu,
JulienVannier66 and
aprentout
and removed request for
a team
8 tasks
phndiaye
force-pushed
the
pn/chore/ember-3.28-upgrade
branch
from
9bd747a to
6fd05fb
Compare
phndiaye
force-pushed
the
pn/remove-unused-ember-tether
branch
from
2b8cc46 to
49bdf90
Compare
phndiaye
changed the title
phndiaye
changed the title
JulienVannier66
approved these changes
Jul 24, 2024
Xegushu
approved these changes
Jul 24, 2024
8 tasks
phndiaye
added a commit
that referenced
this pull request
Jul 25, 2024
* upgrade to ember 3.28 * fix eslintrc * linter fix * [VEL-3593/VEL-3588] Remove unused ember-tether (#397) * remove unused ember-tether * fix Run loop and computed dot access deprecation * remove comments * feature-flagged: fix property access ambiguous path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove unused ember-tether as the addon is not really using it.
This must be merged after: https://github.com/upfluence/ember-influencer/pull/572 & upfluence/hypertable#208
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist