added missing versions to targets

uos · Jan 2, 2025 · 6ba6703 · 6ba6703
1 parent 7d2c003
commit 6ba6703
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 3 deletions.
diff --git a/ext/laslib/CMakeLists.txt b/ext/laslib/CMakeLists.txt
@@ -47,6 +47,12 @@ add_library(lvr2las_static STATIC ${LASLIB_SOURCES})
 
 add_library(lvr2las SHARED ${LASLIB_SOURCES})
 
+set_target_properties(lvr2las
+  PROPERTIES
+    SOVERSION ${lvr2_VERSION_MAJOR}
+    VERSION ${lvr2_VERSION}
+)
+
 install(DIRECTORY inc/ DESTINATION ${LASLIB_INSTALL_INCLUDE_DIR})
 
 install(TARGETS lvr2las_static lvr2las

diff --git a/ext/rply/CMakeLists.txt b/ext/rply/CMakeLists.txt
@@ -13,6 +13,12 @@ add_library(lvr2rply_static STATIC rply.c)
 
 add_library(lvr2rply SHARED rply.c)
 
+set_target_properties(lvr2rply
+  PROPERTIES
+    SOVERSION ${lvr2_VERSION_MAJOR}
+    VERSION ${lvr2_VERSION}
+)
+
 install(DIRECTORY . DESTINATION ${RPLY_INSTALL_INCLUDE_DIR}
   FILES_MATCHING PATTERN "*.h")
 

diff --git a/src/liblvr2/CMakeLists.txt b/src/liblvr2/CMakeLists.txt
@@ -245,12 +245,9 @@ target_compile_definitions(lvr2_static
 set_target_properties(lvr2_static
     PROPERTIES
     EXPORT_NAME lvr2_static
-    SOVERSION ${lvr2_VERSION_MAJOR}
-    VERSION ${lvr2_VERSION}
     CXX_STANDARD 17
 )
 
-
 #####################################################################################
 # Build shared library
 #####################################################################################
@@ -365,6 +362,12 @@ if(CUDA_FOUND)
         ${CUDA_NVRTC_LIBRARY}
     )
 
+    # set_target_properties(lvr2cuda_static
+    # PROPERTIES
+    #     SOVERSION ${lvr2_VERSION_MAJOR}
+    #     VERSION ${lvr2_VERSION}
+    # )
+
     message(STATUS "Building shared LVR CUDA library")
     cuda_add_library(lvr2cuda SHARED ${LVR2_CUDA_CPP_SRC} ${LVR2_CUDA_SRC})
 
@@ -378,6 +381,12 @@ if(CUDA_FOUND)
         ${CUDA_NVRTC_LIBRARY}
     )
 
+    set_target_properties(lvr2cuda
+    PROPERTIES
+        SOVERSION ${lvr2_VERSION_MAJOR}
+        VERSION ${lvr2_VERSION}
+    )
+
     install(
         TARGETS lvr2cuda_static lvr2cuda
         EXPORT lvr2Targets