Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(statetriggers): evaluate StateTriggers before the first layout cycle #19557

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

fix(statetriggers): evaluate StateTriggers before the first layout cycle #19557

wants to merge 5 commits into from

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #19364

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19557/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19557/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 155615 has failed on Uno.UI - CI.

jeromelaban
jeromelaban reviewed Feb 19, 2025
View reviewed changes
src/Uno.UI/UI/Xaml/VisualStateGroup.cs
@@ -150,11 +150,15 @@ private void OnParentChanged(object instance, object key, DependencyObjectParent
if (this.GetParent() is IFrameworkElement fe)
{
OnOwnerElementChanged();
#if !UNO_HAS_ENHANCED_LIFECYCLE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed now? Since it's defined only on wasm, won't it cause issues there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNO_HAS_ENHANCED_LIFECYCLE is defined on skia and wasm. I moved the StateTriggers initialization to EnterImpl to match WinUI, so we no longer need to subscribe to Loaded to initialize StateTriggers on platforms that fire EnterImpl

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19557/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19557/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 155671 has failed on Uno.UI - CI.

@ramezgerges
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19557/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 155980 has failed on Uno.UI - CI.

@jeromelaban jeromelaban marked this pull request as draft March 4, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@Youssef1313 Youssef1313 Youssef1313 left review comments

@MartinZikmund MartinZikmund MartinZikmund approved these changes

@ajpinedam ajpinedam ajpinedam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Gallery][Wasm canary][UI Components -Info Badge] InfoBadge in ListViewItem changes UI when clicked
6 participants
@ramezgerges @unodevops @MartinZikmund @ajpinedam @jeromelaban @Youssef1313