Skip to content

Remove mutable era style #6026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

Remove mutable era style #6026

merged 1 commit into from
Jan 22, 2025

Conversation

Manishearth
Copy link
Member

Part of #2856

@Manishearth Manishearth requested a review from sffc as a code owner January 22, 2025 08:15
@Manishearth Manishearth mentioned this pull request Jan 22, 2025
Closed
37 tasks
sffc
sffc approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference for also expanding this into two types because I think it removes some special-case code

@Manishearth Manishearth merged commit 3cad93c into unicode-org:main Jan 22, 2025
28 checks passed
@Manishearth Manishearth deleted the ethiopian-mutable branch January 22, 2025 18:55
@Manishearth
Copy link
Member Author

I consider it low priority but also a preference of mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manishearth @sffc