Skip to content

2.0 cleanup list #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
34 of 37 tasks
robertbastian opened this issue Dec 1, 2022 · 3 comments
Closed
34 of 37 tasks

2.0 cleanup list #2856

robertbastian opened this issue Dec 1, 2022 · 3 comments
Assignees
Labels
2.0-breaking Changes that are breaking API changes C-meta Component: Relating to ICU4X as a whole S-medium Size: Less than a week (larger bug fix or enhancement)

Comments

@robertbastian
Copy link
Member

robertbastian commented Dec 1, 2022

@robertbastian robertbastian added backlog 2.0-breaking Changes that are breaking API changes labels Dec 1, 2022
@sffc sffc added this to the Backlog milestone Dec 22, 2022
@sffc sffc added C-meta Component: Relating to ICU4X as a whole and removed backlog labels Dec 22, 2022
@sffc sffc modified the milestones: Backlog ⟨P4⟩, ICU4X 2.0 Mar 17, 2023
@Manishearth
Copy link
Member

Properties cleanups:

We should remove all of the free functions:

  • Binary property functions should go on CodePointSetData or whatever
  • Enumerated property functions should live on the relevant property

@Manishearth
Copy link
Member

Manishearth commented Feb 25, 2025

The only leftover items are

  • Make icu4x-datagen CLI --fallback default to Auto
    • We don't have this parameter anymore. @robertbastian ? We do have a Fallback enum in icu4x-datagen but it appears to not be used??
  • Fix name of DateTimeError::UnsupportedField
    • @sffc should look at this. The variant is still there, but I don't know what the name is supposed to be here
  • Consider making AbstractSerializer not use trait objects for the FsExporter in datagen Move FilesystemExporter from trait object to generic #6025
    • This is a stretch issue now.

@Manishearth
Copy link
Member

I generally consider all of these items to be stretch. We should file issues for ones we care about and close this metaissue.

robertbastian added a commit that referenced this issue Feb 26, 2025
@github-project-automation github-project-automation bot moved this from Being worked on to Done in icu4x 2.0 Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-breaking Changes that are breaking API changes C-meta Component: Relating to ICU4X as a whole S-medium Size: Less than a week (larger bug fix or enhancement)
Projects
Status: Done
Development

No branches or pull requests

3 participants