Skip to content

Split DateTime symbols data into length-based chunks #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #3413
, #2856
...
Manishearth opened this issue Jun 29, 2023 · 2 comments
Closed
Tracked by #3413
, #2856
...

Split DateTime symbols data into length-based chunks #3598

Manishearth opened this issue Jun 29, 2023 · 2 comments
Assignees
@sffc
Labels
C-datetime Component: datetime, calendars, time zones
Milestone
2.x Priority ⟨P2⟩

Comments

@Manishearth
Copy link
Member

Manishearth commented Jun 29, 2023 •
edited
Loading

Part of #3413

Currently DateTimeSymbols data contains data for every length of symbol data, regardless of which is requested. We shoudl slice it down into MonthSymbols (which can be long/short/medium/full), WeekSymbols, etc and load just what is needed during data loading.

This is likely a 2.0 candidate (#2856). This will need some investigation.
This was referenced Jun 29, 2023
Closed
Closed
@sffc
Copy link
Member

sffc commented Oct 5, 2023

Partly duplicate of #3865

@sffc sffc self-assigned this Oct 5, 2023
@sffc sffc added the C-datetime Component: datetime, calendars, time zones label Oct 5, 2023
@sffc sffc added this to the 1.4 Blocking ⟨P1⟩ milestone Oct 5, 2023
This was referenced Oct 20, 2023
Merged
Merged
@Manishearth Manishearth moved this to Being worked on in icu4x 2.0 Feb 23, 2024
@Manishearth
Copy link
Member Author

This is done with neo dateformatter.

@github-project-automation github-project-automation bot moved this from Being worked on to Done in icu4x 2.0 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
C-datetime Component: datetime, calendars, time zones
Projects
icu4x 2.0
Status: Done
Milestone
2.x Priority ⟨P2⟩
Development

No branches or pull requests
2 participants
@sffc @Manishearth