Merge breadcrumb bar to top, improve sidebar navigation

[Neha9849]

Changes made:

1. Moved breadcrumb to the top
2. Removed the repo name in the breadcrumb

Fixes #122

[jwflory]

Rebased on latest changes in main.

[jwflory]

Overall, this looks great to me! The breadcrumb navigation is more visually distinct and I think this increases its usefulness. I haven't gone deep on this PR yet, so I am leaving three observations for you to review when you are online next.

---

No. 1: The breadcrumb text is inconsistent whether you are looking at a category index page or a specific page within a category. See below:

Could you dig into this and figure out why the category title is inconsistent?

---

No. 2: The breadcrumb appears on the site homepage, which is not helpful. It should be hidden/excluded if the current page is the site's homepage. See below:

I think this one could be resolved easily by adding a boolean check to only render the breadcrumb bar if the current page does not equal the site homepage.

---

No. 3: Is there a more Hugo-centric way of creating the breadcrumb bar? We currently use custom JavaScript for the breadcrumb bar, which works… but I think some of the issues that are cropping up here are because we are trying to reinvent the wheel. What would a more Hugo-centric way of doing this look like? This does broaden the scope of this change, but it might be worthwhile to take this moment to improve the breadcrumb bar by using some Hugo helper functions and templating to help us create instead of custom JavaScript.

While I have not inspected the following links closely, there seem to be lots of hints on more elegant ways of doing this, like this blog post and this Hugo forum thread. These could be good jumping-off points to figure out what makes the most sense for us.

---

We can chat about this Pull Request in our check-in chat tomorrow! 🙂 You're on the right track here so far, but we can polish this further for a better solution.

[Neha9849]

@jwflory I couldn't figure out why the path was inconsistent.
In single page's the actual behaviour is expected but coming to list page, i don't know why it's showing up like that.
And also, this problem is there even before.

[Neha9849]

Yes, there is a hugo eccentric way of doing it.
I will do this in another PR as of now this PR contains a lot of changes and i think it's kinda hard to maintain.

[Neha9849]

I have removed the breadcrumb in Home page

[Neha9849]

@jwflory I am done with the basic layout.
But there are some changes to be done to the css in the mobile view.
Can you please look in to the desktop view and give a review and also checkout mobile view toggle feature of sidebar.
Do you think it's good or should i make changes to it?

[jwflory]

Taking a look at this now. I probably won't get it reviewed fully before stand-up, but we can discuss this PR and next steps for Sprint 3.

[jwflory]

I tested this locally and the change looks good! 👍🏻 But I want to understand the CSS and template changes better and consider how we load a new dependency (Font Awesome) into the site. There is a lot going on in this PR and I want to review its impact on other components.

For now, I left an in-line note about styling and whitespace. I will complete a more thorough review by the end of the week and leave comments as I go.

[jwflory]

@Neha9849 There is a merge conflict with this PR since we merged #138 before it. I notice this could be a good opportunity to walk through rebasing since the commit size of the Pull Request grew.

We can set up time on Thursday to go through a rebase and also walk through this Pull Request together. I think a call would be faster to go through the questions I have too.

In the meantime, I suggest making a new branch copied from breadcrumbBar and trying rebasing on the latest changes fetched from main. You can make an attempt to solve the merge conflict from your copied branch, and then point your local branch at the remote branch once it is solved. Hopefully we can catch the problem as to why Pull Requests were closed like last time.

[jwflory]

As expected, #138 created another merge conflict here. But since we worked through the major conflicts earlier, this rebase should be straightforward. @Neha9849, drop me a message once you get it rebased or if you hit any blocks! 🙂

I'll finish this review in a couple hours after I take my lunch.

[Neha9849]

@jwflory I did the rebase, it was successful this time🥳
I understand many things in today's session thank you!
I may not understand everything but i will learn it👍

[jwflory]

@Neha9849 wrote…
@jwflory I did the rebase, it was successful this time 🥳 I understand many things in today's session thank you! I may not understand everything but i will learn it 👍

Awesome! 💯 😎 These are advanced git skills we practiced today. But you went through it and did great! Practicing these skills also helps you work together in any distributed, collaborative project, especially when the number of committers grows. Keep it up 👍🏻

Unfortunately, I did not have time today to finish my review. I planned myself too thin for this sprint! Our team's meeting-free Fridays will make it easier for me to give this more focused time.

@Idadelveloper, if you have time on Friday, I would appreciit ate if you could review too. It can help speed this PR up 🙂

[Idadelveloper]

@Neha9849 this is tiny but please fix the typo in line 755 in the CSS file. Should be !important

blockquote p {
    color: var(--text-color-dark) !imporant;
}

[Idadelveloper]

@Neha9849 can you make the breadcrumb text consistent? We should have something like Home>Communities>Fedora rather than Home>communities>fedora.
Also is this how the button looks like from your end?

[Neha9849]

@Neha9849 can you make the breadcrumb text consistent? We should have something like Home>Communities>Fedora rather than Home>communities>fedora.

@Idadelveloper
I have added CSS to do that but seems it's not working maybe some other class CSS is dominating, I will add !important to it and will check out if that works

Also, is this what the button looks like from your end?

yep, I haven't noticed it there is some issue with the width, I will fix it out

[Neha9849]

@Idadelveloper I fixed them
Can you check whether it's good now

[Neha9849]

@jwflory

The layout for the cohorts and teams page is the same as before.
As cohorts and teams pages are having its own layout, this resulted in this problem.
What are your thoughts on this?

[jwflory]

This looks good to me. This is ready to merge. Thanks for working through the rounds of feedback on this one @Neha9849! Merging. 🎬