Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a reader, I want to have the same navigation bar on all pages so that I don't get lost in the layout. #139

Closed
jwflory opened this issue Jul 11, 2022 · 0 comments · Fixed by #141
Closed

As a reader, I want to have the same navigation bar on all pages so that I don't get lost in the layout. #139

jwflory opened this issue Jul 11, 2022 · 0 comments · Fixed by #141
Assignees
@Neha9849
Labels
C: design thinking Planning and creative thinking about design elements in new features or improvements T: bug Something isn't working

Comments

@jwflory
Copy link
Member

jwflory commented Jul 11, 2022

Summary

In PR #133, we added a new layout for the breadcrumb bar and sidebar navigation. However, this layout was not applied to the Team Profiles layouts because they used a different copy of the code.

The scope of this user story is to unify the Team Profiles layouts with the rest of the site so a reader has the same user experience on all pages of the site. This will also help us improve the maintainability of the theme, since more of the common code will be used (instead of duplicating it in a new layout).

Priority

primary

Category

front-end

Type

functional
@jwflory jwflory added T: bug Something isn't working C: design thinking Planning and creative thinking about design elements in new features or improvements labels Jul 11, 2022
@jwflory jwflory moved this from Backlog to Current sprint in Open Source @ OoI Ventures Jul 11, 2022
@Neha9849 Neha9849 mentioned this issue Jul 11, 2022
Merged
jwflory pushed a commit that referenced this issue Jul 12, 2022
@Neha9849
♻️ layouts: Unify cohorts partials with theme layout (#141)
e72c509 
Fixes #139.
Repository owner moved this from Current sprint to Done in Open Source @ OoI Ventures Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Neha9849 Neha9849

Labels
C: design thinking Planning and creative thinking about design elements in new features or improvements T: bug Something isn't working
Projects
Open Source @ OoI Ventures
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modified cohorts and types partials to make it uniform with the theme. Neha9849/inventory-hugo-theme
2 participants
@jwflory @Neha9849