Fix #17758: V15 - Race condition breaks navigation between documents

src/Umbraco.Web.UI.Client/src/packages/core/content-type/structure/content-type-structure-manager.class.ts

@@ -192,8 +192,9 @@ export class UmbContentTypeStructureManager<
 
 	async #loadContentTypeCompositions(ownerContentTypeCompositions: T['compositions'] | undefined) {
 		if (!ownerContentTypeCompositions) {
-			// Owner content type was undefined, so we can not load compositions. But at this point we neither offload existing compositions, this is most likely not a case that needs to be handled.
-			return;
+			// Owner content type was undefined, so we cannot load compositions.
+			// But to clean up existing compositions, we set the array to empty to still be able to execute the clean-up code.
+			ownerContentTypeCompositions = [];
 		}
 
 		const ownerUnique = this.getOwnerContentTypeUnique();

src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts

@@ -112,11 +112,10 @@
 	abstract readonly contentTypeUnique: Observable<string | undefined>;
 
 	/* Data Type */
+	// This dataTypeItemManager is used to load the data type items for this content type, so we have all data-types for this content type up front. [NL]
+	// But once we have a propert application cache this could be solved in a way where we ask the cache for the data type items. [NL]
+	// And then we do not need to store them here in a local manager, but instead just request them here up-front and then again needed(which would get them from the cache, which as well could be update while this runs) [NL]
 	readonly #dataTypeItemManager = new UmbDataTypeItemRepositoryManager(this);
-	/**
-	 * Data Type Schema Map is used for lookup, this should make coder simpler and give better performance. [NL]
-	 */
-	#dataTypeSchemaAliasMap = new Map<string, string>();
 
 	#varies?: boolean;
 	#variesByCulture?: boolean;
@@ -236,19 +235,7 @@
 				this.#dataTypeItemManager.setUniques(dataTypeUniques);
 			},
 			null,
 		);
-		this.observe(
-			this.#dataTypeItemManager.items,
-			(dataTypes) => {
-				// Make a map of the data type unique and editorAlias
-				this.#dataTypeSchemaAliasMap = new Map(
-					dataTypes.map((dataType) => {
-						return [dataType.unique, dataType.propertyEditorSchemaAlias];
-					}),
-				);
-			},
-			null,
-		);
 
 		this.loadLanguages();
 	}
@@ -426,7 +413,10 @@
 			throw new Error(`Property alias "${alias}" not found.`);
 		}
 
-		const editorAlias = this.#dataTypeSchemaAliasMap.get(property.dataType.unique);
+		// the getItemByUnique is a async method that first resolves once the item is loaded.
+		const editorAlias = (await this.#dataTypeItemManager.getItemByUnique(property.dataType.unique))
+			.propertyEditorSchemaAlias;
+		// This means if its not loaded this will never resolve and the error below will never happen.
 		if (!editorAlias) {
 			throw new Error(`Editor Alias of "${property.dataType.unique}" not found.`);
 		}