Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17758: V15 - Race condition breaks navigation between documents #17857

Open
wants to merge 4 commits into
base: v15/dev
Choose a base branch
from
+10 −19

a few notes

447abdc
Select commit
Loading
Failed to load commit list.
Open

Fix #17758: V15 - Race condition breaks navigation between documents #17857

a few notes
447abdc
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) succeeded Dec 20, 2024 in 47s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.02 (8.82 -> 8.84)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Large Method content-detail-workspace-base.ts: constructor

Annotations

Check notice on line 238 in src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ Getting better: Large Method 

constructor decreases from 95 to 84 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis