A permeability model for the excavation damage zone #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norihiro-w
reviewed
Jul 30, 2019
| ) | ||
|
|
||
| # Get all files in the sub-directory | ||
| FILE(GLOB MAT_SOLID_H RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} Material/Solid/*.h) |
There was a problem hiding this comment.
why not move Material dir out of FEM dir?
norihiro-w
reviewed
Jul 30, 2019
| * | ||
| */ | ||
|
|
||
| #pragma once |
norihiro-w
reviewed
Jul 30, 2019
| @@ -181,7 +188,8 @@ bool MMPRead(std::string base_file_name) | |||
| //---------------------------------------------------------------------- | |||
| // OK MMPDelete(); | |||
| //---------------------------------------------------------------------- | |||
| ScreenMessage("MMPRead ... ");; | |||
| ScreenMessage("MMPRead ... "); | |||
| ; | |||
There was a problem hiding this comment.
please delete this empty line
norihiro-w
reviewed
Jul 30, 2019
| @@ -4909,6 +4941,22 @@ double* CMediumProperties::PermeabilityTensor(long index) | |||
| } | |||
| break; | |||
| } | |||
|
|
|||
| if (_damage_zone_permeability == NULL) | |||
There was a problem hiding this comment.
To make it easier to add new cases, I suggest writing the lines as
if (_damage_zone_permeability != NULL)
{
...
}
norihiro-w
reviewed
Jul 30, 2019
|
|
||
| namespace SolidProp | ||
| { | ||
| class MohrCoulombFailureCriterion |
There was a problem hiding this comment.
i think WX has already implemented MohrCoulomb stuff. Isn't it possible to reuse it?
|
@norihiro-w Thanks. I will revise it later on. |
wenqing
force-pushed
the
perm_failure_PR
branch
from
1137c6e to
b94988b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the attached documentation
PermeabilityDamageZone.pdf