This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines:
It changes the default
CFLAGS
for Verilator:-O1
changed to-Os
as it is a default optimization used by Verilator, and using different ones can result in invalid PCH error (Verilator OPTs):-include V$topName.h
removed, as it should not be used according to <command-line>: fatal error: VMockArrayTestbench__pch.h.fast: No such file or directory verilator/verilator#5244 (comment)Moreover, PR improves formatting of displayed commands - e.g. values used for
-CFLAGS
are wrapped with quote.