Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Fix invalid PCH error #738

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

eszpotanski
Copy link
Contributor

This PR combines:

It changes the default CFLAGS for Verilator:

Moreover, PR improves formatting of displayed commands - e.g. values used for -CFLAGS are wrapped with quote.

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2024

CLA assistant check
All committers have signed the CLA.

@oharboe
Copy link
Contributor

oharboe commented Jul 29, 2024

@jackkoenig 🥳

@eszpotanski
Copy link
Contributor Author

Unrelated CI fail, due to the timeout for newer Verilator version (like on main) and missing SBT on mac

@nndurj
Copy link

nndurj commented Aug 2, 2024

does this work with the latest verilator?

@eszpotanski
Copy link
Contributor Author

Yes, I've tested it with verilator 5.026 and with master branch (Verilator 5.027 devel rev v5.026-77-g1600cc01a) using built-in test:

$ sbt "testOnly chiseltest.** -- -n RequiresVerilator"
[...]
[info] Run completed in 2 minutes, 1 second.
[info] Total number of tests run: 95
[info] Suites: completed 134, aborted 0
[info] Tests: succeeded 95, failed 0, canceled 0, ignored 1, pending 0
[info] All tests passed.
[success] Total time: 123 s (02:03), completed Aug 2, 2024, 11:11:44 AM

Changes were also tested on example from The-OpenROAD-Project/OpenROAD-flow-scripts#2120

Copy link
Collaborator

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekiwi ekiwi merged commit da2b67b into ucb-bar:main Aug 6, 2024
25 of 31 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants