Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GH action on PR instead of push #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Run GH action on PR instead of push #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/hugo_ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: Hugo Build and Deploy

on: push
on:
pull_request:
types: [opened, reopened, closed]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
types: [opened, reopened, closed]
types: [opened, synchronize]

i think this is what we use to run on new PRs and new commits on PR?

branches:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify branch in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was based on @michaelfitzo's comment about PRs targeting main/master. Probably overzealous, but didn't want to cause confusion by pushing changes merged to a feature branch to alpha.gen3.org.

- 'master'

env:
BASE_URL: ${{ (github.ref == 'refs/heads/master' && 'gen3.org') || 'alpha.gen3.org' }}
Expand Down
Loading