Run GH action on PR instead of push #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfshao
reviewed
Aug 29, 2024
| on: | ||
| pull_request: | ||
| types: [opened, reopened, closed] | ||
| branches: |
There was a problem hiding this comment.
I don't think we need to specify branch in here?
There was a problem hiding this comment.
That was based on @michaelfitzo's comment about PRs targeting main/master. Probably overzealous, but didn't want to cause confusion by pushing changes merged to a feature branch to alpha.gen3.org.
| on: push | ||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, closed] |
There was a problem hiding this comment.
Suggested change
| types: [opened, reopened, closed] | |
| types: [opened, synchronize] |
i think this is what we use to run on new PRs and new commits on PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes