Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable comments on Jest testing #51

Merged
merged 10 commits into from
Jun 24, 2024
14 changes: 3 additions & 11 deletions .github/workflows/jest-testing.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
name: Run Jest testing suite
on:
workflow_dispatch:
workflow_run:
workflows: ["Build"]
types:
- completed
pull_request:

env:
NODE_ENV: "test"
Expand All @@ -22,10 +19,5 @@ jobs:
with:
fetch-depth: 0

- name: Jest With Coverage Comment
# Ensures this step is run even on previous step failure (e.g. test failed)
if: always()
uses: ArtiomTr/jest-coverage-report-action@v2
with:
package-manager: yarn
prnumber: ${{ github.event.pull_request.number || github.event.workflow_run.pull_requests[0].number }}
- name: Jest With Coverage
run: yarn install --immutable --immutable-cache --check-cache && yarn test
1 change: 1 addition & 0 deletions cypress/e2e/main.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ describe("Homepage tests", () => {
});
cy.get("@consoleError").should("not.be.called");
cy.get("body").should("exist");
cy.get("h1").should("exist");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very relevant to this PR, just adding more coverage while I was testing, so I thought it could remain there.

});
});
1 change: 1 addition & 0 deletions static/main.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
export async function mainModule() {
console.log(`Hello from mainModule`);
}

mainModule()
.then(() => {
console.log("mainModule loaded");
Expand Down