fix: disable comments on Jest testing #51
Conversation
|
No more comment is posted, only the result can be visible within the Action run itself: https://github.com/ubiquity/ts-template/actions/runs/9617643273/job/26529830238?pr=51#step:4:41 If that is satisfactory, I will also apply this within https://github.com/ubiquibot/plugin-template I do not know if that is interesting to have but we could also add the summary on the Action run like so: https://github.com/Meniole/ts-template/actions/runs/9617961749/attempts/1#summary-26530846974 |
|
Summary on the action seems like a good solution. Just as long as you verify that it doesn't produce a notification. |
|
@0x4007 I should hopefully not. If it ever does, I will remove this section right away. But afaik, since it's just tied to the Action run itself, it should not. This run has the summary linked to itself. |
| @@ -7,5 +7,6 @@ describe("Homepage tests", () => { | |||
| }); | |||
| cy.get("@consoleError").should("not.be.called"); | |||
| cy.get("body").should("exist"); | |||
| cy.get("h1").should("exist"); | |||
There was a problem hiding this comment.
Not very relevant to this PR, just adding more coverage while I was testing, so I thought it could remain there.
Resolves #50