feat: private key formats #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
requested changes
Sep 7, 2024
Keyrxng
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
I think this might be good to have in the SDK as any plugin which needs access to funds will need it.
It makes it easier for plugin devs to be bad actors, swap out prod workers for malicious ones and logging PKs etc but that's a partner's choice to use unofficial plugins I guess isn't it
whilefoo
suggested changes
Sep 8, 2024
There was a problem hiding this comment.
The decrypt functions should be exported in src/index.ts if we want to use it in conversation-rewards
Fixed 114a9cf |
whilefoo
approved these changes
Sep 9, 2024
This was referenced Sep 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ubiquity-os/ubiquity-os-kernel#104
Right now there is an issue when a malicious partner can copy other partner's encrypted private key and use it in its own organization.
This PR introduces 3 private key formats:
PRIVATE_KEYPRIVATE_KEY:GITHUB_ORGANIZATION_IDPRIVATE_KEY:GITHUB_ORGANIZATION_ID:GITHUB_REPOSITORY_IDYou may read how they're supposed to be used here.
The next step is to validate organization and repository in the https://github.com/ubiquibot/conversation-rewards plugin if they are allowed to be used in the organization/repository where original issue was called from.