Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to main #63

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Dev to main #63

merged 6 commits into from
Sep 9, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Sep 9, 2024

No description provided.

@rndquu rndquu merged commit fd05a11 into main Sep 9, 2024
5 checks passed
@0x4007
Copy link
Member

0x4007 commented Sep 9, 2024

I think let's not do these anymore. Let's just target development instead of main

@rndquu
Copy link
Member Author

rndquu commented Sep 12, 2024

I think let's not do these anymore. Let's just target development instead of main

The issue with this approach is that every breaking change or bug breaks the conversation-rewards plugin since we're using the latest available version of the permit-generation package here.

For example this PR introduced breaking changes. With the "target development" approach the conversation-rewards plugin would start failing immediately. While with our current approach (development + main branch for releases) we have time for preparing necessary changes in the conversation-rewards plugin keeping backwards compatibility.

@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

I think let's not do these anymore. Let's just target development instead of main

The issue with this approach is that every breaking change or bug breaks the conversation-rewards plugin since we're using the latest available version of the permit-generation package here.

Yes I understand that. The feedback loop is significantly faster if we do what I'm saying because we run it in various scenarios.

Besides, in a pinch we could just revert. In reality we would likely be able to push a fix as soon as a problem is noticed.

This is obviously to speed up development cycles while we can afford to have crashes in production.

Our team throughput has been low in the last month and we need to do everything we can to pick up the pace.

@rndquu
Copy link
Member Author

rndquu commented Sep 13, 2024

I think let's not do these anymore. Let's just target development instead of main

The issue with this approach is that every breaking change or bug breaks the conversation-rewards plugin since we're using the latest available version of the permit-generation package here.

Yes I understand that. The feedback loop is significantly faster if we do what I'm saying because we run it in various scenarios.

Besides, in a pinch we could just revert. In reality we would likely be able to push a fix as soon as a problem is noticed.

This is obviously to speed up development cycles while we can afford to have crashes in production.

Our team throughput has been low in the last month and we need to do everything we can to pick up the pace.

#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants