Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong linked PR is closed on /stop #4

Closed
rndquu opened this issue Jun 25, 2024 · 16 comments · Fixed by #10
Closed

Wrong linked PR is closed on /stop #4

rndquu opened this issue Jun 25, 2024 · 16 comments · Fixed by #10

Comments

@rndquu
Copy link
Member

rndquu commented Jun 25, 2024

Depends on #1

Check this /stop command. The bot (i.e. ubiquibot/command-start-stop plugin) closed the issue but also tried to close a linked PR although this PR is from a different repo with different assignee.

What should be done:

  • make sure the plugin closes the correct linked PRs
  • write a regression test
@0x4007
Copy link
Member

0x4007 commented Jun 25, 2024

Interesting that this problem persisted in both versions. I assumed this logic was rewritten from scratch

Copy link

ubiquibot bot commented Jul 29, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot-dev bot commented Jul 29, 2024

[ 25 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Conversation Incentives
Comment Formatting Relevance Reward

[ 7.09 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.48
Review Comment 7 6.61
Conversation Incentives
Comment Formatting Relevance Reward
Interesting that this problem persisted in both versions. I assu…
1.6
content:
  p:
    count: 16
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.3 0.48
I always open up my pull body with "Resolves #0". Are we sure th…
2.6
content:
  p:
    count: 25
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.6 1.56
Seems unusual that you added this directive. I suppose it doesn'…
2.9
content:
  p:
    count: 29
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.2 0.58
This enabled stuff should be removed.
0.6
content:
  p:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.1 0.06
Can you demonstrate how the config would look if you wanted to d…
1.7
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.4 0.68
This doesn't seem right. Configuration merging should be at the …
4.6
content:
  p:
    count: 39
    score: 1
  code:
    count: 7
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.2 0.92
Ideally we should have support for all the above scenarios. Cros…
3.4
content:
  p:
    count: 34
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.8 2.72
After my comments are addressed I'm okay to merge.
0.9
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.1 0.09

[ 17.1 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Issue Specification 1 17.1
Conversation Incentives
Comment Formatting Relevance Reward
Depends on https://github.com/ubiquibot/command-start-stop/pull/…
17.10000000000000228
content:
  p:
    count: 53
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 3
1 17.1

[ 0 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Review Comment 22 0
Conversation Incentives
Comment Formatting Relevance Reward
Why are these ignored?
0.4
content:
  p:
    count: 4
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
```suggestion const userToUnassign = assignees.fin…
1.8
content:
  p:
    count: 9
    score: 1
  code:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
The problem I noticed with this, is that in our issue template w…
4.2
content:
  p:
    count: 40
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
```suggestion ```
0.2
content:
  p:
    count: 1
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
You are correct I put plural by accident, singular makes sense.
1.1
content:
  p:
    count: 11
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
I meant that the `prBody` would be like: ```…
3
content:
  p:
    count: 23
    score: 1
  code:
    count: 7
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
Are these actually used? Is knip actually running on this branch…
2.6
content:
  p:
    count: 25
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
This issue also exists in other repos sadly.
0.8
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
Isn't the logger supposed to also generate the diff?
0.9
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
If the `main` is not recognized possibly some files will…
3.3
content:
  p:
    count: 32
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
I think a quick fix that would be reliable is to remove comment,…
3
content:
  p:
    count: 30
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
It does resolve it properly wherever it is located, except HTML …
1.7
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
@Keyrxng So in the end are these needed?
0.8
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
@Keyrxng Yes but these dependencies are actually never imported …
2.9
content:
  p:
    count: 28
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
This is the recommended format from [the docs](https://typescrip…
5.1
content:
  p:
    count: 46
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
I guess this was to mimic the v1 that actually had a field to di…
2.7
content:
  p:
    count: 27
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
Currently, the repo configuration will override the organization…
5.3
content:
  p:
    count: 52
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
No. If it is enabled organization level, it will be enabled in e…
4.9
content:
  p:
    count: 47
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
Yes, implemented [here for example](https://github.com/ubiquibot…
0.8
content:
  p:
    count: 5
    score: 1
  a:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
```yml plugins: # any plugin you want except com…
3.7
content:
  p:
    count: 28
    score: 1
  code:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
The thing is the id is arbitrary, and not even required. Plus, e…
12.9
content:
  p:
    count: 98
    score: 1
  code:
    count: 31
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
@Keyrxng Yes, the merge issue is unrelated to this and will be a…
2.2
content:
  p:
    count: 22
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
``` Second one is a comment and should be ignored.", "url": "https://github.com//pull/10#discussion_r1687272960", "type": 81, "score": { "formatting": { "content": { "p": { "count": 23, "score": 1 }, "code": { "count": 7, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "Are these actually used? Is knip actually running on this branch during the tests? I suspect it runs on the `development` branch to post this.", "url": "https://github.com//pull/10#discussion_r1687273632", "type": 81, "score": { "formatting": { "content": { "p": { "count": 25, "score": 1 }, "code": { "count": 1, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "This issue also exists in other repos sadly.", "url": "https://github.com//pull/10#discussion_r1687287576", "type": 81, "score": { "formatting": { "content": { "p": { "count": 8, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "Isn't the logger supposed to also generate the diff?", "url": "https://github.com//pull/10#discussion_r1688398642", "type": 81, "score": { "formatting": { "content": { "p": { "count": 9, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "If the `main` is not recognized possibly some files will be considered as unused because they are reference through the main. But in other projects we never needed to ignore these files.", "url": "https://github.com//pull/10#discussion_r1689063529", "type": 81, "score": { "formatting": { "content": { "p": { "count": 32, "score": 1 }, "code": { "count": 1, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "I think a quick fix that would be reliable is to remove comment, by using a substring with a regex, so comments are ignored, then your logic should be good.", "url": "https://github.com//pull/10#discussion_r1689064144", "type": 81, "score": { "formatting": { "content": { "p": { "count": 30, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "It does resolve it properly wherever it is located, except HTML comments that are also properly ignored.", "url": "https://github.com//pull/10#discussion_r1689121092", "type": 81, "score": { "formatting": { "content": { "p": { "count": 17, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "@Keyrxng So in the end are these needed?", "url": "https://github.com//pull/10#discussion_r1692782551", "type": 81, "score": { "formatting": { "content": { "p": { "count": 8, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "@Keyrxng Yes but these dependencies are actually never imported anywhere in the codebase from what I see, so Knip message makes sense, they can be removed from `package.json`.", "url": "https://github.com//pull/10#discussion_r1693709052", "type": 81, "score": { "formatting": { "content": { "p": { "count": 28, "score": 1 }, "code": { "count": 1, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "This is the recommended format from [the docs](https://typescript-eslint.io/getting-started/#step-2-configuration). And indeed the `ts-check` enforces the same checks as the other files (would not by default since it is `js`). This is now used everywhere when `eslint` was updated to the latest version, as it became the standard.", "url": "https://github.com//pull/10#discussion_r1694073055", "type": 81, "score": { "formatting": { "content": { "p": { "count": 46, "score": 1 }, "a": { "count": 2, "score": 1 }, "code": { "count": 3, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "I guess this was to mimic the v1 that actually had a field to disable the start stop command, which I don't think is needed for v2.", "url": "https://github.com//pull/10#discussion_r1694094078", "type": 81, "score": { "formatting": { "content": { "p": { "count": 27, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "Currently, the repo configuration will override the organization repo. There is an issue on that topic [here](https://github.com/ubiquity-os/ubiquity-os-kernel/issues/54). I would say that if in the target repository configuration, the plugin is not mentioned, it won't run (or be disabled if you will). If it is present, the target repo configuration will be used.", "url": "https://github.com//pull/10#discussion_r1694217749", "type": 81, "score": { "formatting": { "content": { "p": { "count": 52, "score": 1 }, "a": { "count": 1, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "No. If it is enabled organization level, it will be enabled in every repo. I a repo defines a configuration with `command-start-stop` in it, it will override totally the organization configuration. If a repo defines a configuration without `command-start-stop` then it will never run on that repo.", "url": "https://github.com//pull/10#discussion_r1694221964", "type": 81, "score": { "formatting": { "content": { "p": { "count": 47, "score": 1 }, "code": { "count": 2, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "Yes, implemented [here for example](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/75#issuecomment-2253656887).", "url": "https://github.com//pull/10#discussion_r1694229369", "type": 81, "score": { "formatting": { "content": { "p": { "count": 5, "score": 1 }, "a": { "count": 3, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "```yml plugins: # any plugin you want except command-start-stop ``` I still have to think on the configuration merging because we changed the whole shape of the configuration file.", "url": "https://github.com//pull/10#discussion_r1694572780", "type": 81, "score": { "formatting": { "content": { "p": { "count": 28, "score": 1 }, "code": { "count": 9, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "The thing is the id is arbitrary, and not even required. Plus, each plugin can pack a plugin chain where execution is chained with a list of plugins so they pass down their data to the next one. ```yml plugins: - id: plugin-1 name: First plugin chain with: - uses: ubiquibot/conversation-rewards - uses: ubiquibot/autoamted-merging - id: plugin-2 name: Second plugin chain with: - uses: https://ubiquit-assistive-pricing.workers.dev - uses: ubiquibot/conversation-rewards ``` I think merging by `id` would simplify a lot the problem, however you cannot guess what id was used by the Org configuration if you cannot see the configuration file.", "url": "https://github.com//pull/10#discussion_r1695035846", "type": 81, "score": { "formatting": { "content": { "p": { "count": 98, "score": 1 }, "code": { "count": 31, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } }, { "content": "@Keyrxng Yes, the merge issue is unrelated to this and will be addressed within the kernel. I am fine with this pull-request.", "url": "https://github.com//pull/10#issuecomment-2255750147", "type": 81, "score": { "formatting": { "content": { "p": { "count": 22, "score": 1 } }, "wordValue": 0.1, "formattingMultiplier": 1 }, "reward": 0, "relevance": 0 } } ], "evaluationCommentHtml": "

[ 0 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Review Comment 22 0
Conversation Incentives
Comment Formatting Relevance Reward
Why are these ignored?
0.4
content:
  p:
    count: 4
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
```suggestion const userToUnassign = assignees.fin…
1.8
content:
  p:
    count: 9
    score: 1
  code:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
The problem I noticed with this, is that in our issue template w…
4.2
content:
  p:
    count: 40
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
```suggestion ```
0.2
content:
  p:
    count: 1
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
You are correct I put plural by accident, singular makes sense.
1.1
content:
  p:
    count: 11
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
I meant that the `prBody` would be like: ```…
3
content:
  p:
    count: 23
    score: 1
  code:
    count: 7
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
Are these actually used? Is knip actually running on this branch…
2.6
content:
  p:
    count: 25
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
This issue also exists in other repos sadly.
0.8
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
Isn't the logger supposed to also generate the diff?
0.9
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
If the `main` is not recognized possibly some files will…
3.3
content:
  p:
    count: 32
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
I think a quick fix that would be reliable is to remove comment,…
3
content:
  p:
    count: 30
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
It does resolve it properly wherever it is located, except HTML …
1.7
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
@Keyrxng So in the end are these needed?
0.8
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
@Keyrxng Yes but these dependencies are actually never imported …
2.9
content:
  p:
    count: 28
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
This is the recommended format from [the docs](https://typescrip…
5.1
content:
  p:
    count: 46
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
I guess this was to mimic the v1 that actually had a field to di…
2.7
content:
  p:
    count: 27
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
Currently, the repo configuration will override the organization…
5.3
content:
  p:
    count: 52
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
No. If it is enabled organization level, it will be enabled in e…
4.9
content:
  p:
    count: 47
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
Yes, implemented [here for example](https://github.com/ubiquibot…
0.8
content:
  p:
    count: 5
    score: 1
  a:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
```yml plugins: # any plugin you want except com…
3.7
content:
  p:
    count: 28
    score: 1
  code:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
The thing is the id is arbitrary, and not even required. Plus, e…
12.9
content:
  p:
    count: 98
    score: 1
  code:
    count: 31
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
@Keyrxng Yes, the merge issue is unrelated to this and will be a…
2.2
content:
  p:
    count: 22
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
" } } -->

Copy link

ubiquibot bot commented Jul 29, 2024

[ 6 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment11.6
ReviewComment24.4
Conversation Incentives
CommentFormattingRelevanceReward
Interesting that this problem persisted in both versions. I assu...
1.60.711.6
> I think there may be legitimate scenarios where a PR exists...
3.40.743.4
After my comments are addressed I'm okay to merge....
10.781

[ 2.3 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
ReviewComment12.3
Conversation Incentives
CommentFormattingRelevanceReward
@Keyrxng Yes, the merge issue is unrelated to this and will be a...
2.30.5352.3

[ 80.8 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueTask125
ReviewComment427.9
ReviewComment427.9
Conversation Incentives
CommentFormattingRelevanceReward
> Cross org indeed is rare. If its too complicated then perha...
5.40.75.4
I want to add that even with the example in the PR body it would...
13.2
code:
  count: 1
  score: "1"
  words: 2
0.713.2
I've added the PR body check

I referenced the issue from anot...

8.30.7458.3
just double checking that we are good to merge here...
10.741
> Cross org indeed is rare. If its too complicated then perha...
5.40.75.4
I want to add that even with the example in the PR body it would...
13.2

code:
  count: 1
  score: "1"
  words: 2
0.713.2
I've added the PR body check

I referenced the issue from anot...

8.30.7458.3
just double checking that we are good to merge here...
10.741

[ 18.6 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification118.6
Conversation Incentives
CommentFormattingRelevanceReward
Depends on https://github.com/ubiquibot/command-start-stop/pull/...
18.6
a:
  count: 2
  score: "2"
  words: 2
li:
  count: 2
  score: "2"
  words: 13
code:
  count: 2
  score: "2"
  words: 5
118.6

@gentlementlegen
Copy link
Member

Seems to be a little formatting issue, will open a ticket about it.

Copy link

ubiquibot bot commented Aug 14, 2024

+ Evaluating results. Please wait...

Copy link

ubiquityos bot commented Aug 14, 2024

[ 296.2 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Review Comment 19 271.2
Conversation Incentives
Comment Formatting Relevance Reward
Resolves https://github.com/ubiquibot/command-start-stop/issues/…
0
content:
  p:
    count: 4
    score: 1
  ul:
    count: 73
    score: 0
  li:
    count: 73
    score: 1
  pre:
    count: 21
    score: 0
  code:
    count: 21
    score: 1
wordValue: 0
formattingMultiplier: 0
0.9 -
https://github.com/ubiquibot/command-start-stop/pull/10#issuecom…
6.8
content:
  p:
    count: 17
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 6.8
Should we use a plural when it only returns a singular user? and…
12.4
content:
  p:
    count: 30
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 12.4
hmm, the `"pull_request" in source` check should elimina…
25.2
content:
  p:
    count: 60
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 25.2
I see my mistake, if this confirmation via PR body is the way to…
11.6
content:
  p:
    count: 29
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 11.6
the workflow runs on `pull_request_target` and the actio…
17.2
content:
  p:
    count: 40
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 17.2
what do you suggest then, avoid using this sort of approach all …
9.2
content:
  p:
    count: 23
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 9.2
I forgot about that @gentlementlegen [QA](https://github.com/u…
2.8
content:
  p:
    count: 6
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 2.8
Solved for html comments but even still I expect to see some tee…
14
content:
  p:
    count: 35
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 14
resolved
0.4
content:
  p:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 0.4
@gentlementlegen https://github.com/ubiquibot/command-start-stop…
8.8
content:
  p:
    count: 20
    score: 1
  a:
    count: 2
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 8.8
Ah I was on auto-pilot thinking they were in the action entry bu…
6.4
content:
  p:
    count: 16
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 6.4
I disagree. How can we disable it on specific repos with this re…
9.2
content:
  p:
    count: 23
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 9.2
So it would be active globally via the org and if there is no co…
23.6
content:
  p:
    count: 59
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 23.6
Right okay I'm following so far. So the pattern we've been usi…
27.6
content:
  p:
    count: 62
    score: 1
  code:
    count: 6
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 27.6
I think a new task if required is the way to go. Correct me if…
20
content:
  p:
    count: 50
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 20
I want to add that even with the example in the PR body it would…
44.8
content:
  p:
    count: 110
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 44.8
I've added the PR body check I referenced the issue from anothe…
27.2
content:
  p:
    count: 68
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 27.2
just double checking that we are good to merge here
4
content:
  p:
    count: 10
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 4

[ 21.48 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.48
Review Comment 8 21
Conversation Incentives
Comment Formatting Relevance Reward
Interesting that this problem persisted in both versions. I assu…
1.6
content:
  p:
    count: 16
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.3 0.48
I always open up my pull body with "Resolves #0". Are we sure th…
2.6
content:
  p:
    count: 25
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.6
Seems unusual that you added this directive. I suppose it doesn'…
2.9
content:
  p:
    count: 29
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.9
This enabled stuff should be removed.
0.6
content:
  p:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.6
Can you demonstrate how the config would look if you wanted to d…
1.7
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 1.7
This doesn't seem right. Configuration merging should be at the …
3.8
content:
  p:
    count: 32
    score: 1
  pre:
    count: 6
    score: 0
  code:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 3.8
The bot has access to private repositories. Using the bot authen…
5.1
content:
  p:
    count: 51
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 5.1
Ideally we should have support for all the above scenarios. Cros…
3.4
content:
  p:
    count: 34
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 3.4
After my comments are addressed I'm okay to merge.
0.9
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.9

[ 14.69 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.065
Review Comment 22 14.625
Conversation Incentives
Comment Formatting Relevance Reward
Seems to be a little formatting issue, will open a ticket about …
0.325
content:
  p:
    count: 13
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
0.2 0.065
Why are these ignored?
0.1
content:
  p:
    count: 4
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.1
```suggestion const userToUnassign = assignees.fi…
0.2
content:
  pre:
    count: 8
    score: 0
  code:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
The problem I noticed with this, is that in our issue template w…
1.05
content:
  p:
    count: 40
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.05
```suggestion ```
0.025
content:
  pre:
    count: 1
    score: 0
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.025
You are correct I put plural by accident, singular makes sense.
0.275
content:
  p:
    count: 11
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.275
I meant that the `prBody` would be like: ```…
0.6
content:
  p:
    count: 17
    score: 1
  code:
    count: 7
    score: 1
  pre:
    count: 6
    score: 0
wordValue: 0.1
formattingMultiplier: 0.25
1 0.6
Are these actually used? Is knip actually running on this branc…
0.65
content:
  p:
    count: 25
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.65
This issue also exists in other repos sadly.
0.2
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
Isn't the logger supposed to also generate the diff?
0.225
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.225
If the `main` is not recognized possibly some files will…
0.825
content:
  p:
    count: 32
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.825
I think a quick fix that would be reliable is to remove comment,…
0.75
content:
  p:
    count: 30
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.75
It does resolve it properly wherever it is located, except HTML …
0.425
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.425
@Keyrxng So in the end are these needed?
0.2
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
@Keyrxng Yes but these dependencies are actually never imported …
0.725
content:
  p:
    count: 28
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.725
This is the recommended format from [the docs](https://typescrip…
1.275
content:
  p:
    count: 46
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.275
I guess this was to mimic the v1 that actually had a field to di…
0.675
content:
  p:
    count: 27
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.675
Currently, the repo configuration will override the organization…
1.325
content:
  p:
    count: 52
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.325
No. If it is enabled organization level, it will be enabled in e…
1.225
content:
  p:
    count: 47
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.225
Yes, implemented [here for example](https://github.com/ubiquibot…
0.2
content:
  p:
    count: 5
    score: 1
  a:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
```yml plugins: # any plugin you want except c…
0.675
content:
  pre:
    count: 8
    score: 0
  code:
    count: 8
    score: 1
  p:
    count: 19
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.675
The thing is the id is arbitrary, and not even required. Plus, e…
2.45
content:
  p:
    count: 68
    score: 1
  pre:
    count: 29
    score: 0
  code:
    count: 30
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 2.45
@Keyrxng Yes, the merge issue is unrelated to this and will be a…
0.55
content:
  p:
    count: 22
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.55

[ 16.5 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Issue Specification 1 16.5
Conversation Incentives
Comment Formatting Relevance Reward
Depends on https://github.com/ubiquibot/command-start-stop/pull/…
16.5
content:
  p:
    count: 38
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 2
    score: 1
  ul:
    count: 13
    score: 0
  li:
    count: 13
    score: 1
wordValue: 0.1
formattingMultiplier: 3
1 16.5

Copy link

ubiquibot bot commented Aug 14, 2024

[ 6 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment11.6
ReviewComment24.4
Conversation Incentives
CommentFormattingRelevanceReward
Interesting that this problem persisted in both versions. I assu...
1.60.491.6
> I think there may be legitimate scenarios where a PR exists...
3.40.733.4
After my comments are addressed I'm okay to merge....
10.791

[ 3.6 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment11.3
ReviewComment12.3
Conversation Incentives
CommentFormattingRelevanceReward
Seems to be a little formatting issue, will open a ticket about ...
1.30.441.3
@Keyrxng Yes, the merge issue is unrelated to this and will be a...
2.30.5852.3

[ 80.8 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueTask125
ReviewComment427.9
ReviewComment427.9
Conversation Incentives
CommentFormattingRelevanceReward
> Cross org indeed is rare. If its too complicated then perha...
5.40.735.4
I want to add that even with the example in the PR body it would...
13.2
code:
  count: 1
  score: "1"
  words: 2
0.73513.2
I've added the PR body check

I referenced the issue from anot...

8.30.7458.3
just double checking that we are good to merge here...
10.7451
> Cross org indeed is rare. If its too complicated then perha...
5.40.735.4
I want to add that even with the example in the PR body it would...
13.2

code:
  count: 1
  score: "1"
  words: 2
0.73513.2
I've added the PR body check

I referenced the issue from anot...

8.30.7458.3
just double checking that we are good to merge here...
10.7451

[ 18.6 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification118.6
Conversation Incentives
CommentFormattingRelevanceReward
Depends on https://github.com/ubiquibot/command-start-stop/pull/...
18.6
a:
  count: 2
  score: "2"
  words: 2
li:
  count: 2
  score: "2"
  words: 13
code:
  count: 2
  score: "2"
  words: 5
118.6

@0x4007
Copy link
Member

0x4007 commented Aug 15, 2024

[ 296.2 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Review Comment 19 271.2
Conversation Incentives
Comment Formatting Relevance Reward
Resolves https://github.com/ubiquibot/command-start-stop/issues/…
0
content:
  p:
    count: 4
    score: 1
  ul:
    count: 73
    score: 0
  li:
    count: 73
    score: 1
  pre:
    count: 21
    score: 0
  code:
    count: 21
    score: 1
wordValue: 0
formattingMultiplier: 0
0.9 -
https://github.com/ubiquibot/command-start-stop/pull/10#issuecom…
6.8
content:
  p:
    count: 17
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 6.8
Should we use a plural when it only returns a singular user? and…
12.4
content:
  p:
    count: 30
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 12.4
hmm, the `"pull_request" in source` check should elimina…
25.2
content:
  p:
    count: 60
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 25.2
I see my mistake, if this confirmation via PR body is the way to…
11.6
content:
  p:
    count: 29
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 11.6
the workflow runs on `pull_request_target` and the actio…
17.2
content:
  p:
    count: 40
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 17.2
what do you suggest then, avoid using this sort of approach all …
9.2
content:
  p:
    count: 23
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 9.2
I forgot about that @gentlementlegen [QA](https://github.com/u…
2.8
content:
  p:
    count: 6
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 2.8
Solved for html comments but even still I expect to see some tee…
14
content:
  p:
    count: 35
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 14
resolved
0.4
content:
  p:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 0.4
@gentlementlegen https://github.com/ubiquibot/command-start-stop…
8.8
content:
  p:
    count: 20
    score: 1
  a:
    count: 2
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 8.8
Ah I was on auto-pilot thinking they were in the action entry bu…
6.4
content:
  p:
    count: 16
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 6.4
I disagree. How can we disable it on specific repos with this re…
9.2
content:
  p:
    count: 23
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 9.2
So it would be active globally via the org and if there is no co…
23.6
content:
  p:
    count: 59
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 23.6
Right okay I'm following so far. So the pattern we've been usi…
27.6
content:
  p:
    count: 62
    score: 1
  code:
    count: 6
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 27.6
I think a new task if required is the way to go. Correct me if…
20
content:
  p:
    count: 50
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 20
I want to add that even with the example in the PR body it would…
44.8
content:
  p:
    count: 110
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 44.8
I've added the PR body check I referenced the issue from anothe…
27.2
content:
  p:
    count: 68
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 27.2
just double checking that we are good to merge here
4
content:
  p:
    count: 10
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 4

[ 21.48 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.48
Review Comment 8 21
Conversation Incentives
Comment Formatting Relevance Reward
Interesting that this problem persisted in both versions. I assu…
1.6
content:
  p:
    count: 16
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.3 0.48
I always open up my pull body with "Resolves #0". Are we sure th…
2.6
content:
  p:
    count: 25
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.6
Seems unusual that you added this directive. I suppose it doesn'…
2.9
content:
  p:
    count: 29
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.9
This enabled stuff should be removed.
0.6
content:
  p:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.6
Can you demonstrate how the config would look if you wanted to d…
1.7
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 1.7
This doesn't seem right. Configuration merging should be at the …
3.8
content:
  p:
    count: 32
    score: 1
  pre:
    count: 6
    score: 0
  code:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 3.8
The bot has access to private repositories. Using the bot authen…
5.1
content:
  p:
    count: 51
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 5.1
Ideally we should have support for all the above scenarios. Cros…
3.4
content:
  p:
    count: 34
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 3.4
After my comments are addressed I'm okay to merge.
0.9
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.9

[ 14.69 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.065
Review Comment 22 14.625
Conversation Incentives
Comment Formatting Relevance Reward
Seems to be a little formatting issue, will open a ticket about …
0.325
content:
  p:
    count: 13
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
0.2 0.065
Why are these ignored?
0.1
content:
  p:
    count: 4
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.1
```suggestion const userToUnassign = assignees.fi…
0.2
content:
  pre:
    count: 8
    score: 0
  code:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
The problem I noticed with this, is that in our issue template w…
1.05
content:
  p:
    count: 40
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.05
```suggestion ```
0.025
content:
  pre:
    count: 1
    score: 0
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.025
You are correct I put plural by accident, singular makes sense.
0.275
content:
  p:
    count: 11
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.275
I meant that the `prBody` would be like: ```…
0.6
content:
  p:
    count: 17
    score: 1
  code:
    count: 7
    score: 1
  pre:
    count: 6
    score: 0
wordValue: 0.1
formattingMultiplier: 0.25
1 0.6
Are these actually used? Is knip actually running on this branc…
0.65
content:
  p:
    count: 25
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.65
This issue also exists in other repos sadly.
0.2
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
Isn't the logger supposed to also generate the diff?
0.225
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.225
If the `main` is not recognized possibly some files will…
0.825
content:
  p:
    count: 32
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.825
I think a quick fix that would be reliable is to remove comment,…
0.75
content:
  p:
    count: 30
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.75
It does resolve it properly wherever it is located, except HTML …
0.425
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.425
@Keyrxng So in the end are these needed?
0.2
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
@Keyrxng Yes but these dependencies are actually never imported …
0.725
content:
  p:
    count: 28
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.725
This is the recommended format from [the docs](https://typescrip…
1.275
content:
  p:
    count: 46
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.275
I guess this was to mimic the v1 that actually had a field to di…
0.675
content:
  p:
    count: 27
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.675
Currently, the repo configuration will override the organization…
1.325
content:
  p:
    count: 52
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.325
No. If it is enabled organization level, it will be enabled in e…
1.225
content:
  p:
    count: 47
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.225
Yes, implemented [here for example](https://github.com/ubiquibot…
0.2
content:
  p:
    count: 5
    score: 1
  a:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
```yml plugins: # any plugin you want except c…
0.675
content:
  pre:
    count: 8
    score: 0
  code:
    count: 8
    score: 1
  p:
    count: 19
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.675
The thing is the id is arbitrary, and not even required. Plus, e…
2.45
content:
  p:
    count: 68
    score: 1
  pre:
    count: 29
    score: 0
  code:
    count: 30
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 2.45
@Keyrxng Yes, the merge issue is unrelated to this and will be a…
0.55
content:
  p:
    count: 22
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.55

[ 16.5 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Issue Specification 1 16.5
Conversation Incentives
Comment Formatting Relevance Reward
Depends on https://github.com/ubiquibot/command-start-stop/pull/…
16.5
content:
  p:
    count: 38
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 2
    score: 1
  ul:
    count: 13
    score: 0
  li:
    count: 13
    score: 1
wordValue: 0.1
formattingMultiplier: 3
1 16.5

@gentlementlegen the assignee should not be eligible for review rewards. I assume our config supports this already. Can you make the necessary adjustments for both organizations and link the commits here?

@gentlementlegen
Copy link
Member

gentlementlegen commented Aug 15, 2024

@0x4007 So you mean that Keyrxng here should have had 0 for Review comments correct?


Changed here and here.

Copy link

ubiquibot bot commented Aug 15, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Aug 15, 2024

@Keyrxng the deadline is at 2024-08-15T09:58:09.949Z

Copy link

ubiquityos bot commented Aug 15, 2024

[ 25 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Review Comment 19 0
Conversation Incentives
Comment Formatting Relevance Reward
Resolves https://github.com/ubiquibot/command-start-stop/issues/…
0
content:
  p:
    count: 4
    score: 1
  ul:
    count: 73
    score: 0
  li:
    count: 73
    score: 1
  pre:
    count: 21
    score: 0
  code:
    count: 21
    score: 1
wordValue: 0
formattingMultiplier: 0
0.9 -
https://github.com/ubiquibot/command-start-stop/pull/10#issuecom…
0
content:
  p:
    count: 17
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
Should we use a plural when it only returns a singular user? and…
0
content:
  p:
    count: 30
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
hmm, the `"pull_request" in source` check should elimina…
0
content:
  p:
    count: 60
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
I see my mistake, if this confirmation via PR body is the way to…
0
content:
  p:
    count: 29
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
the workflow runs on `pull_request_target` and the actio…
0
content:
  p:
    count: 40
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
what do you suggest then, avoid using this sort of approach all …
0
content:
  p:
    count: 23
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
I forgot about that @gentlementlegen [QA](https://github.com/u…
0
content:
  p:
    count: 6
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
Solved for html comments but even still I expect to see some tee…
0
content:
  p:
    count: 35
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
resolved
0
content:
  p:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
@gentlementlegen https://github.com/ubiquibot/command-start-stop…
0
content:
  p:
    count: 20
    score: 1
  a:
    count: 2
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
Ah I was on auto-pilot thinking they were in the action entry bu…
0
content:
  p:
    count: 16
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
I disagree. How can we disable it on specific repos with this re…
0
content:
  p:
    count: 23
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
So it would be active globally via the org and if there is no co…
0
content:
  p:
    count: 59
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
Right okay I'm following so far. So the pattern we've been usi…
0
content:
  p:
    count: 62
    score: 1
  code:
    count: 6
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
I think a new task if required is the way to go. Correct me if…
0
content:
  p:
    count: 50
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
I want to add that even with the example in the PR body it would…
0
content:
  p:
    count: 110
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
I've added the PR body check I referenced the issue from anothe…
0
content:
  p:
    count: 68
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
just double checking that we are good to merge here
0
content:
  p:
    count: 10
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -

[ 22.11 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 2 1.11
Review Comment 8 21
Conversation Incentives
Comment Formatting Relevance Reward
Interesting that this problem persisted in both versions. I assu…
1.6
content:
  p:
    count: 16
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.5 0.8
@gentlementlegen the assignee should not be eligible for review…
3.1
content:
  p:
    count: 31
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.1 0.31
I always open up my pull body with "Resolves #0". Are we sure th…
2.6
content:
  p:
    count: 25
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.6
Seems unusual that you added this directive. I suppose it doesn'…
2.9
content:
  p:
    count: 29
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.9
This enabled stuff should be removed.
0.6
content:
  p:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.6
Can you demonstrate how the config would look if you wanted to d…
1.7
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 1.7
This doesn't seem right. Configuration merging should be at the …
3.8
content:
  p:
    count: 32
    score: 1
  pre:
    count: 6
    score: 0
  code:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 3.8
The bot has access to private repositories. Using the bot authen…
5.1
content:
  p:
    count: 51
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 5.1
Ideally we should have support for all the above scenarios. Cros…
3.4
content:
  p:
    count: 34
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 3.4
After my comments are addressed I'm okay to merge.
0.9
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.9

[ 14.75 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Comment 2 0.125
Review Comment 22 14.625
Conversation Incentives
Comment Formatting Relevance Reward
Seems to be a little formatting issue, will open a ticket about …
0.325
content:
  p:
    count: 13
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
0.2 0.065
@0x4007 So you mean that Keyrxng here should have had `0`…
0.6
content:
  h2:
    count: 15
    score: 1
  code:
    count: 3
    score: 1
  p:
    count: 4
    score: 1
  a:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
0.1 0.06
Why are these ignored?
0.1
content:
  p:
    count: 4
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.1
```suggestion const userToUnassign = assignees.fi…
0.2
content:
  pre:
    count: 8
    score: 0
  code:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
The problem I noticed with this, is that in our issue template w…
1.05
content:
  p:
    count: 40
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.05
```suggestion ```
0.025
content:
  pre:
    count: 1
    score: 0
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.025
You are correct I put plural by accident, singular makes sense.
0.275
content:
  p:
    count: 11
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.275
I meant that the `prBody` would be like: ```…
0.6
content:
  p:
    count: 17
    score: 1
  code:
    count: 7
    score: 1
  pre:
    count: 6
    score: 0
wordValue: 0.1
formattingMultiplier: 0.25
1 0.6
Are these actually used? Is knip actually running on this branc…
0.65
content:
  p:
    count: 25
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.65
This issue also exists in other repos sadly.
0.2
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
Isn't the logger supposed to also generate the diff?
0.225
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.225
If the `main` is not recognized possibly some files will…
0.825
content:
  p:
    count: 32
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.825
I think a quick fix that would be reliable is to remove comment,…
0.75
content:
  p:
    count: 30
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.75
It does resolve it properly wherever it is located, except HTML …
0.425
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.425
@Keyrxng So in the end are these needed?
0.2
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
@Keyrxng Yes but these dependencies are actually never imported …
0.725
content:
  p:
    count: 28
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.725
This is the recommended format from [the docs](https://typescrip…
1.275
content:
  p:
    count: 46
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.275
I guess this was to mimic the v1 that actually had a field to di…
0.675
content:
  p:
    count: 27
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.675
Currently, the repo configuration will override the organization…
1.325
content:
  p:
    count: 52
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.325
No. If it is enabled organization level, it will be enabled in e…
1.225
content:
  p:
    count: 47
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 1.225
Yes, implemented [here for example](https://github.com/ubiquibot…
0.2
content:
  p:
    count: 5
    score: 1
  a:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.2
```yml plugins: # any plugin you want except c…
0.675
content:
  pre:
    count: 8
    score: 0
  code:
    count: 8
    score: 1
  p:
    count: 19
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.675
The thing is the id is arbitrary, and not even required. Plus, e…
2.45
content:
  p:
    count: 68
    score: 1
  pre:
    count: 29
    score: 0
  code:
    count: 30
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 2.45
@Keyrxng Yes, the merge issue is unrelated to this and will be a…
0.55
content:
  p:
    count: 22
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
1 0.55

[ 16.5 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Issue Specification 1 16.5
Conversation Incentives
Comment Formatting Relevance Reward
Depends on https://github.com/ubiquibot/command-start-stop/pull/…
16.5
content:
  p:
    count: 38
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 2
    score: 1
  ul:
    count: 13
    score: 0
  li:
    count: 13
    score: 1
wordValue: 0.1
formattingMultiplier: 3
1 16.5

Copy link

ubiquibot bot commented Aug 15, 2024

[ 46.1 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment241.7
ReviewComment24.4
Conversation Incentives
CommentFormattingRelevanceReward
Interesting that this problem persisted in both versions. I assu...
1.6-1.6
> <details> <summary> <b> ...
40.1
a:
  count: 8
  score: "8"
  words: 12
code:
  count: 29
  score: "29"
  words: 201
-40.1
> I think there may be legitimate scenarios where a PR exists...
3.40.713.4
After my comments are addressed I'm okay to merge....
10.8151

[ 10.5 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment28.2
ReviewComment12.3
Conversation Incentives
CommentFormattingRelevanceReward
Seems to be a little formatting issue, will open a ticket about ...
1.3-1.3
@0x4007 So you mean that Keyrxng here should have had `0`...
6.9
a:
  count: 2
  score: "2"
  words: 2
code:
  count: 2
  score: "2"
  words: 3
hr:
  count: 1
  score: "1"
  words: 0
-6.9
@Keyrxng Yes, the merge issue is unrelated to this and will be a...
2.30.5152.3

[ 80.8 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueTask125
ReviewComment427.9
ReviewComment427.9
Conversation Incentives
CommentFormattingRelevanceReward
> Cross org indeed is rare. If its too complicated then perha...
5.40.75.4
I want to add that even with the example in the PR body it would...
13.2
code:
  count: 1
  score: "1"
  words: 2
0.7613.2
I've added the PR body check

I referenced the issue from anot...

8.30.688.3
just double checking that we are good to merge here...
10.71
> Cross org indeed is rare. If its too complicated then perha...
5.40.75.4
I want to add that even with the example in the PR body it would...
13.2

code:
  count: 1
  score: "1"
  words: 2
0.7613.2
I've added the PR body check

I referenced the issue from anot...

8.30.688.3
just double checking that we are good to merge here...
10.71

[ 18.6 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification118.6
Conversation Incentives
CommentFormattingRelevanceReward
Depends on https://github.com/ubiquibot/command-start-stop/pull/...
18.6
a:
  count: 2
  score: "2"
  words: 2
li:
  count: 2
  score: "2"
  words: 13
code:
  count: 2
  score: "2"
  words: 5
118.6

@gentlementlegen
Copy link
Member

@0x4007 Is that what you intended?

@0x4007
Copy link
Member

0x4007 commented Aug 15, 2024

Okay let's see how relevance scoring works. Perhaps I am biased but I am expecting something closer to v1 scoring, just because I fine tuned its config over some months to get what I think kind of makes sense.

Let's run this again once that capability is merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants