Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting issue #76

Closed
gentlementlegen opened this issue Jul 29, 2024 · 15 comments · Fixed by #55
Closed

Formatting issue #76

gentlementlegen opened this issue Jul 29, 2024 · 15 comments · Fixed by #55

Comments

@gentlementlegen
Copy link
Member

There seem to be some formatting issue in the pull-request:
ubiquity-os-marketplace/command-start-stop#4 (comment)

The comment should not be displayed in this case.

@0x4007
Copy link
Member

0x4007 commented Jul 30, 2024

Why not study the old code closer to see why we don't have these problems?

@gentlementlegen
Copy link
Member Author

The old code was totally broken when it came to formatting as well and would cut the results instead. This is an issue regarding the metadata part I think.

@gentlementlegen gentlementlegen self-assigned this Aug 13, 2024
Copy link

ubiquibot bot commented Aug 13, 2024

@gentlementlegen the deadline is at 2024-08-13T07:38:43.182Z

@gentlementlegen
Copy link
Member Author

@0x4007 It seems that the problem was solved after my changes in #78, see results here by ubiquityos: ubiquity-os-marketplace/command-start-stop#4 (comment). Shall this be closed as completed or not planned?

@0x4007
Copy link
Member

0x4007 commented Aug 15, 2024

You should retroactively link your pull to this issue. Then we have a formal record for audits, and you receive your credit.

However as you know, we generally require targeted pulls (only the relevant changes per one issue) but we can make an exception here.

@gentlementlegen
Copy link
Member Author

@0x4007 Yes I agree, I guess everything went in in one block because we needed the v2 release last week, and because the other task overlapped with this one (and this fix was needed to have everything running properly).
The issue was fixed from this commit: 6b512c5

Copy link

ubiquibot bot commented Aug 15, 2024

+ Evaluating results. Please wait...

Copy link

ubiquityos bot commented Aug 15, 2024

! Failed to run comment evaluation. Error: execution reverted (no data present; likely require(false) occurred (action="call", data="0x", reason="require(false)", transaction={ "data": "0x95d89b41", "to": "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d" }, invocation=null, revert=null, code=CALL_EXCEPTION, version=6.13.1)

Copy link

ubiquibot bot commented Aug 15, 2024

[ 6.1 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment26.1
Conversation Incentives
CommentFormattingRelevanceReward
Why not study the old code closer to see why we don't have these...
1.60.471.6
You should retroactively link your pull to this issue. Then we h...
4.50.684.5

[ 82.8 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification16.2
IssueTask150
IssueComment326.6
IssueComment30
Conversation Incentives
CommentFormattingRelevanceReward
There seem to be some formatting issue in the pull-request: htt...
6.216.2
The old code was totally broken when it came to formatting as we...
5.80.645.8
@0x4007 It seems that the problem was solved after my changes in...
10
code:
  count: 1
  score: "1"
  words: 1
0.7910
@0x4007 Yes I agree, I guess everything went in in one block bec...
10.80.8110.8
The old code was totally broken when it came to formatting as we...
-0.64-
@0x4007 It seems that the problem was solved after my changes in...
-
code:
  count: 1
  score: "0"
  words: 1
0.79-
@0x4007 Yes I agree, I guess everything went in in one block bec...
-0.81-

Copy link

ubiquibot bot commented Aug 20, 2024

@gentlementlegen the deadline is at 2024-08-20T11:14:56.843Z

Copy link

ubiquibot bot commented Aug 20, 2024

+ Evaluating results. Please wait...

Copy link

ubiquityos bot commented Aug 20, 2024

[ 73.16 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 50
Issue Specification 1 6
Issue Comment 3 17.16
Conversation Incentives
Comment Formatting Relevance Reward
There seem to be some formatting issue in the pull-request: htt…
6
content:
  p:
    count: 20
    score: 1
wordValue: 0.1
formattingMultiplier: 3
1 6
The old code was totally broken when it came to formatting as we…
5.8
content:
  p:
    count: 29
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.7 4.06
@0x4007 It seems that the problem was solved after my changes in…
5.8
content:
  p:
    count: 28
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.8 4.64
@0x4007 Yes I agree, I guess everything went in in one block bec…
9.4
content:
  p:
    count: 47
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.9 8.46

[ 3.15 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 2 3.15
Conversation Incentives
Comment Formatting Relevance Reward
Why not study the old code closer to see why we don't have these…
1.5
content:
  p:
    count: 15
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.3 0.45
You should retroactively link your pull to this issue. Then we h…
4.5
content:
  p:
    count: 45
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.6 2.7

Copy link

ubiquibot bot commented Aug 20, 2024

[ 6.1 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment26.1
Conversation Incentives
CommentFormattingRelevanceReward
Why not study the old code closer to see why we don't have these...
1.60.451.6
You should retroactively link your pull to this issue. Then we h...
4.50.6354.5

[ 82.8 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification16.2
IssueTask150
IssueComment326.6
IssueComment30
Conversation Incentives
CommentFormattingRelevanceReward
There seem to be some formatting issue in the pull-request: htt...
6.216.2
The old code was totally broken when it came to formatting as we...
5.80.675.8
@0x4007 It seems that the problem was solved after my changes in...
10
code:
  count: 1
  score: "1"
  words: 1
0.7610
@0x4007 Yes I agree, I guess everything went in in one block bec...
10.80.8510.8
The old code was totally broken when it came to formatting as we...
-0.67-
@0x4007 It seems that the problem was solved after my changes in...
-
code:
  count: 1
  score: "0"
  words: 1
0.76-
@0x4007 Yes I agree, I guess everything went in in one block bec...
-0.85-

@gentlementlegen
Copy link
Member Author

@0x4007 Seems that updating the packages fixed the issue, at least for now.

@0x4007
Copy link
Member

0x4007 commented Aug 22, 2024

@gentlementlegen Please link the correct pull

@gentlementlegen gentlementlegen linked a pull request Aug 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants