Start/Stop plugin

[Keyrxng]

Resolves ubiquity-os/plugins-wishlist#9

[github-actions]

Lines	Statements	Branches	Functions
	80% (4/5)	100% (0/0)	66.66% (2/3)

JUnit

Tests	Skipped	Failures	Errors	Time
1	0 💤	0 ❌	0 🔥	2.749s ⏱️

Coverage Report (80%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	80	100	66.66	80
main.ts	80	100	66.66	80	9

[Keyrxng]

[rndquu]

@Keyrxng The plugin config example provided in the README throws SyntaxError: "[object Object]" is not valid JSON (I'm using this one). Could you update README with a ready to use example?

[gentlementlegen]

@Keyrxng Worflows will crash because of yarn version not defined within the workflow (corepack enable)

error This project's package.json defines "packageManager": "[email protected]". However the current global version of Yarn is 1.22.22.

[gentlementlegen]

Just tested again an it seems there would be some formatting issues.

Second thing is a problem with the linked PRs as seen in this test. This one should have been filtered out.

Otherwise the logic is working.

[0x4007]

Just tested again an it seems there would be some formatting issues.

This has always existed. It's fine to ship like this until we can figure a solution later (I couldn't)

Second thing is a problem with the linked PRs as seen in this test. This one should have been filtered out.

Otherwise the logic is working.

[gentlementlegen]

@0x4007 I mentioned it because I think it worsened, if you look at our current bot

so I thought it'd be easier to track the root of the issue. But it can be a separate issue, surely this is not urgent.

[Keyrxng]

Second thing is a problem with the linked PRs as seen in Meniole/todel#6 (comment). This one should have been filtered out.

• close only assignee prs #5 it was advised to address it in another PR but I can merge that into this PR if it's easier @gentlementlegen

we can figure a solution later (I couldn't)

I also spent some time on this as one of my first contributions, no luck either. But it annoys me too so I'm going to give it another try in this PR.

[gentlementlegen]

@Keyrxng Let's have those fixed in a separate PR.

[gentlementlegen]

@Keyrxng If you could address the remaining comments so we can merge this would be nice 😄

[Keyrxng]

Latest QA

• test ubq-testing/command-start-stop#1 (comment)

Not sure if this is better, but I remember seeing this render in a diff block so there's no need to dress it up if formatting isn't supported.

It was previously rendered in a diff block and formatting is not supported. I have listed them to support formatting with your suggestion but without the diff effects. Should it be rendered in a diff block @0x4007?

• testing ubq-testing/command-start-stop#2 (comment)

[0x4007]

Match as close as possible to how it was and I can fix it later or something

[Keyrxng]

@0x4007 ubq-testing#2 (comment)

[gentlementlegen]

Please fix my last comment and good to go for me.

[Keyrxng]

Would I merge this since everyone has approved or are we still waiting on @rndquu?

[gentlementlegen]

@Keyrxng Should be good to go.