Skip to content

Commit

Permalink
Fix CONTINUE_ON_ERROR
Browse files Browse the repository at this point in the history
Cannot use ici_timed as this would call ici_exit on failure
  • Loading branch information
rhaschke committed Sep 10, 2023
1 parent b8935bf commit eb53bea
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,12 @@ function build_source {
total="$(echo "$pkg_paths" | wc -l)"

for pkg_path in $pkg_paths; do
if ! ici_timed "Building package $count/$total: $pkg_path" build_pkg "$pkg_path"; then
test "$CONTINUE_ON_ERROR" = false && exit 1 || FAIL_EVENTUALLY=1
ici_time_start "Building package $count/$total: $pkg_path"
if ! build_pkg "$pkg_path"; then
gha_warning "Failed to build package $pkg_path"
test "$CONTINUE_ON_ERROR" = false && ici_exit 1 || FAIL_EVENTUALLY=1
fi
ici_time_end
count=$((count + 1))
done

Expand Down

0 comments on commit eb53bea

Please sign in to comment.