-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make datetime input more flexible for az_hourly() #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comment on az_hourly.R
, the function works as expected. The changes to datetime
input offer a nice added convenience.
Co-authored-by: Jeremy Weiss <[email protected]>
Co-authored-by: Jeremy Weiss <[email protected]>
Co-authored-by: Jeremy Weiss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad you caught the timezone detail! Also, I like the user feedback messages, which I'm learning are important when it comes to UI-UX-web-data-viz work.
Ok! I think this is finally ready for another round of review. Again, you can safely ignore all the changes in .json files in |
Co-authored-by: Jeremy Weiss <[email protected]>
Co-authored-by: Jeremy Weiss <[email protected]>
Co-authored-by: Jeremy Weiss <[email protected]>
Co-authored-by: Jeremy Weiss <[email protected]>
Co-authored-by: Jeremy Weiss <[email protected]>
Addresses #44 to allow dates alone to be passed to
az_hourly()
. When a date is passed toend_date_time
the results contain data through the end of that date.This one was tricky because while the AZMet API uses 23:59:59 for midnight rather than 00:00:00, it considers the time interval between 23:00:00 and 23:59:59 exactly one hour. This has made the
parse_params()
function need to be fairly complicated. Would be happy to simplify things if there are any obvious ways to do so.The data retrieval functions now print messages whenever
parse_params()
is "filling in gaps" in inputs. E.g. start and end not supplied, end not supplied, or end not supplied to hour precision (for datetimes).Other changes: