remove httptest2 API mocking infrastructure #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially used
httptest2to make tests more robust and not rely on a live API to pass. However, with the date and time specific messages introduced in #62, these mocks became less useful for many tests. Ultimately, I think it is simpler to not worry about mocking API requests and just skip tests when the API is down and on CRAN (shouldazmeteventually be submitted to CRAN). API mocking is more important when you have zero control over what the API does, but that's not the case forazmetr.I discovered some timezone issues along the way also.