Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatcher: test cleanup #3749

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Dispatcher: test cleanup #3749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/shared/src/test/scala/cats/effect/std/DispatcherSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ class DispatcherSpec extends BaseSpec with DetectPlatform {
implicit ticker =>
val test = dispatcher.allocated.flatMap {
case (runner, release) =>
IO(runner.unsafeRunAndForget(IO.sleep(50.millis) *> release)) *>
IO(runner.unsafeRunAndForget(release)) *>
Comment on lines 360 to +363
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was briefly confused why we added this sleep in the first place, for a ticked test ... and it's because in #3593 it was originally a real test and the sleep helped avoid the race condition where the release started while the unsafeRunAndForget was still executing.

tl;dr this test is a lot more robust now.

IO.sleep(100.millis) *>
IO(runner.unsafeRunAndForget(IO(ko)) must throwAn[IllegalStateException])
}
Expand Down
Loading