Dispatcher: test cleanup #3749
Merged
Dispatcher: test cleanup #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that this sleep is no longer necessary now that the `alive` resource, and it's associated race condition, has been removed.
armanbilge
approved these changes
Jul 15, 2023
Comment on lines
360
to
+363
| implicit ticker => | ||
| val test = dispatcher.allocated.flatMap { | ||
| case (runner, release) => | ||
| IO(runner.unsafeRunAndForget(IO.sleep(50.millis) *> release)) *> | ||
| IO(runner.unsafeRunAndForget(release)) *> |
There was a problem hiding this comment.
I was briefly confused why we added this sleep in the first place, for a ticked test ... and it's because in #3593 it was originally a real test and the sleep helped avoid the race condition where the release started while the unsafeRunAndForget was still executing.
tl;dr this test is a lot more robust now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just removing the extra sleep that was added here: #3593. The sleep was added as part of a short-term fix for flakiness and now that the second check on alive (and possible cancellation of the submitted task) is gone, this test shouldn't flake.
I added a
.replicateA(20000)on line 366 to convince myself that this was stable 🤞🏻